[WIP] Add emoji order #21
Closed
+3,584
−1,792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanwiesel
force-pushed
the
emoji-order
branch
from
4485a7c to
1b90b00
Compare
jonathanwiesel
force-pushed
the
emoji-order
branch
from
1b90b00 to
709ddb0
Compare
jonathanwiesel
force-pushed
the
master
branch
2 times, most recently
from
8ed5cb1 to
d22c08c
Compare
|
Is there anything left to contribute to this enhancement? I see this has been open for a while but the |
|
Hi @LukeeeeBennett, sorry for the late response, indeed there are some issues with the order in the source repo regarding the following: Since the source repo will push an update for 3.0 soon it's posible this would be solved in that version. Until then there's not much to do with this. |
|
Are there no updates for this yet? Hope to see this update soon. 😄 |
|
Ordered categories have been added in 4.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some stuff need to be taken care for this to be consistent:
emoji_orderinstead of alphabeticallyAfter number 1624 it skips to 10000. (could be because those on the 10000 are the new unicode 9 emoji an there is no official ordered yet, but not sure).
After 10074 it skips to 10080.
10100 and 10102 are missing.
What I was able to check from the source repo is that:
speech_leftthat was removed in the latest release. Could think on adding it back (yet it seems weird this definition has this order).gay_pride_flagthat is not even part of the assets yet.This would resolve #20
This is related to joypixels/emojione#309