Moving instance var loading into yml file

Author: robertIngrum

config/model_properties.yml

@@ -0,0 +1,100 @@
+---
+Natero::Base:
+  source: ~
+  properties:
+
+Natero::Account:
+  source: http://apidocs.natero.com/apidoc.html#Accounts
+  properties:
+  - account_id
+  - name
+  - join_date
+  - renewal_date
+  - billing_account_id
+  - support_account_id
+  - crm_account_id
+  - billing_street
+  - billing_city
+  - billing_postal_code
+  - billing_state
+  - billing_country
+  - phone
+  - employees
+  - industry
+  - tier
+  - csm_score
+  - current_nps_score
+  - sales_rep_name
+  - sales_rep_email
+  - source
+  - stage
+  - is_deleted
+  - is_churned
+  - inactive_time
+  - inactive_reason
+  - parent_account_id
+  - hierarchy_label
+  - is_leaf
+  - latest_status_title
+  - latest_status_details
+  - latest_status_date
+  - assigned_csms
+  - custom_label_dimensions
+  - custom_value_dimensions
+  - custom_event_dimensions
+  - stage_history
+  - nps_history
+
+Natero::Event:
+  source: http://apidocs.natero.com/restapi.html
+  properties:
+  - account_id
+  - action
+  - active_duration
+  - created_at
+  - details
+  - feature
+  - module
+  - product
+  - session_id
+  - time_spent
+  - total
+  - user_id
+
+Natero::Metric:
+  source: http://apidocs.natero.com/apidoc.html#Custom%20Metrics
+  properties:
+  - account_id
+  - name
+  - metrics
+  - direction
+  - page
+
+Natero::User:
+  source: http://apidocs.natero.com/apidoc.html#Accounts%20Product%20Users
+  properties:
+  - user_id
+  - account_id
+  - first_name
+  - last_name
+  - contact_user_id
+  - phone
+  - mobile_phone
+  - email
+  - salutation
+  - title
+  - role
+  - department
+  - source
+  - mailing_street
+  - mailing_city
+  - mailing_state
+  - mailing_postal_code
+  - mailing_country
+  - lead_source
+  - product_join_date
+  - is_active
+  - custom_label_dimensions
+  - custom_value_dimensions
+  - custom_event_dimensions
+...

lib/natero.rb

@@ -40,6 +40,10 @@ def self.api_key_uri
   def self.to_records_json(objects)
     "{\"records\": #{Array(objects).map(&:serialize)}}".to_s.delete('\\').gsub('"{', '{').gsub('}"', '}')
   end
+
+  def self.gem_root
+    File.expand_path('../..', __FILE__)
+  end
 end
 
 require_relative 'natero/serializable'

lib/natero/base.rb

@@ -39,14 +39,22 @@ def initialize(params, raw_response = nil)
     missing_params = REQUIRED_PARAMS - params.keys
     raise ArgumentError.new("Missing required params #{missing_params.join(', ')}") unless missing_params.empty?
 
-    params.each do |k, v|
-      instance_variable_set("@#{k}", v)
-      self.class.class_eval { attr_reader :"#{k}" }
-    end
+    load_properties(params)
     @raw_response = raw_response
   end
 
   def to_json
     serialize
   end
+
+  def load_properties(params)
+    model_config_file = "#{Natero.gem_root}/config/model_properties.yml"
+    model_config = YAML::load(File.read(model_config_file))[self.class.name.to_s].with_indifferent_access
+    model_config[:properties].each do |prop|
+      next unless params.include?(prop.to_sym)
+
+      instance_variable_set("@#{prop}", params[prop.to_sym])
+      self.class.class_eval { attr_reader prop.to_sym }
+    end
+  end
 end

spec/natero/event_spec.rb

@@ -49,7 +49,7 @@
       details = 'detail!'
       request_url = "https://events.natero.com/v1/#{event_auth_key}/#{event_api_key}"
       data = {body: {id:1, name:'test', action:'identifyAccount', details: details},
-              header: {'Content-Type': 'application/json'}}
+              headers: {'Content-Type': 'application/json'}}
       method = :post
 
       expect(HTTParty).to receive(method).with(request_url, data).and_return(valid_message)