Skip to content

Commit 45e3856

Browse files
committed
Fix rubocop offences
1 parent 6739cd7 commit 45e3856

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

lib/bootstrap_form/inputs/check_box.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ def check_box_wrapper_class(options)
6868
classes << "form-check-inline" if layout_inline?(options[:inline])
6969
classes << "mb-3" unless options[:multiple] || layout == :horizontal
7070
classes << "form-switch" if options[:switch]
71-
classes << options[:wrapper][:class] if options.dig(:wrapper, :class).present?
72-
classes << options[:wrapper_class] if options[:wrapper_class].present?
71+
classes << options.dig(:wrapper, :class).presence
72+
classes << options[:wrapper_class].presence
7373
classes.flatten.compact
7474
end
7575
end

lib/bootstrap_form/inputs/radio_button.rb

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ module RadioButton
99
included do
1010
def radio_button_with_bootstrap(name, value, *args)
1111
options = args.extract_options!.symbolize_keys!
12-
radio_button_options = options.except(:class, :label, :label_class, :error_message, :help,
13-
:inline, :hide_label, :skip_label, :wrapper, :wrapper_class)
14-
15-
radio_button_options[:class] = radio_button_classes(name, options)
16-
17-
tag.div(class: radio_button_wrapper_class(options), **options[:wrapper].to_h.except(:class)) do
18-
html = radio_button_without_bootstrap(name, value, radio_button_options)
12+
wrapper_attributes = options[:wrapper] || {}
13+
wrapper_attributes[:class] = radio_button_wrapper_class(options)
14+
tag.div(**wrapper_attributes) do
15+
html = radio_button_without_bootstrap(name, value, radio_button_options(name, options))
1916
html.concat(radio_button_label(name, value, options)) unless options[:skip_label]
2017
html.concat(generate_error(name)) if options[:error_message]
2118
html
@@ -27,6 +24,13 @@ def radio_button_with_bootstrap(name, value, *args)
2724

2825
private
2926

27+
def radio_button_options(name, options)
28+
radio_button_options = options.except(:class, :label, :label_class, :error_message, :help,
29+
:inline, :hide_label, :skip_label, :wrapper, :wrapper_class)
30+
radio_button_options[:class] = radio_button_classes(name, options)
31+
radio_button_options
32+
end
33+
3034
def radio_button_label(name, value, options)
3135
label_options = { value: value, class: radio_button_label_class(options) }
3236
label_options[:for] = options[:id] if options[:id].present?
@@ -51,8 +55,8 @@ def radio_button_wrapper_class(options)
5155
classes = ["form-check"]
5256
classes << "form-check-inline" if layout_inline?(options[:inline])
5357
classes << "disabled" if options[:disabled]
54-
classes << options[:wrapper][:class] if options.dig(:wrapper, :class).present?
55-
classes << options[:wrapper_class] if options[:wrapper_class].present?
58+
classes << options.dig(:wrapper, :class).presence
59+
classes << options[:wrapper_class].presence
5660
classes.flatten.compact
5761
end
5862
end

0 commit comments

Comments
 (0)