Merge pull request #36 from mhaylock/fix_3x_db_commands_for_nonstandard_homebrew_location

Update 3.x to run db commands from the right dir

Author: dgoodlad

manifests/db.pp

@@ -10,12 +10,12 @@
 
   exec { "postgresql-db-${name}":
     command => join([
-      'createdb',
+      "${postgresql::bindir}/createdb",
       "-p${postgresql::port}",
       '-E UTF-8',
       "-O ${postgresql::user}",
       $name
     ], ' '),
-    unless  => "psql -aA -p${postgresql::port} -t -l | cut -d \\| -f 1 | grep -w '${name}'"
+    unless  => "${postgresql::bindir}/psql -aA -p${postgresql::port} -t -l | cut -d \\| -f 1 | grep -w '${name}'"
   }
 }

manifests/init.pp

@@ -6,6 +6,7 @@
 class postgresql(
   $ensure     = $postgresql::params::ensure,
 
+  $bindir     = $postgresql::params::bindir,
   $executable = $postgresql::params::executable,
 
   $host       = $postgresql::params::host,

manifests/params.pp

@@ -5,7 +5,8 @@
     Darwin: {
       include boxen::config
 
-      $executable = "${boxen::config::homebrewdir}/bin/postgres"
+      $bindir     = "${boxen::config::homebrewdir}/bin"
+      $executable = "${bindir}/postgres"
       $datadir    = "${boxen::config::datadir}/postgresql-9.3"
       $logdir     = "${boxen::config::logdir}/postgresql-9.3"
       $port       = 15432
@@ -20,6 +21,7 @@
 
     Ubuntu: {
       $executable = undef # only used on Darwin
+      $bindir     = '/usr/bin'
       $datadir    = '/var/lib/postgresql'
       $logdir     = '/var/log/postgresql'
       $port       = 5432

manifests/service.pp

@@ -5,6 +5,7 @@
   $service = $postgresql::params::service,
   $enable  = $postgresql::params::enable,
 
+  $bindir  = $postgresql::params::bindir,
   $datadir = $postgresql::params::datadir,
   $host    = $postgresql::params::host,
   $port    = $postgresql::params::port,
@@ -27,7 +28,7 @@
   }
 
   exec { 'init-postgresql-db':
-    command => "initdb -E UTF-8 ${datadir}",
+    command => "${bindir}/initdb -E UTF-8 ${datadir}",
     creates => "${datadir}/PG_VERSION",
   }
 

spec/defines/postgresql_db_spec.rb

@@ -8,8 +8,8 @@
     should include_class("postgresql")
 
     should contain_exec("postgresql-db-#{title}").with({
-      :command => "createdb -p15432 -E UTF-8 -O testuser #{title}",
-      :unless  => "psql -aA -p15432 -t -l | cut -d \\| -f 1 | grep -w '#{title}'"
+      :command => "/test/boxen/homebrew/bin/createdb -p15432 -E UTF-8 -O testuser #{title}",
+      :unless  => "/test/boxen/homebrew/bin/psql -aA -p15432 -t -l | cut -d \\| -f 1 | grep -w '#{title}'"
     })
   end
 end