Regression: simple-binding.aps

[boyland]

Scheduling example/simple-binding.aps shows several problems:

1. Warning on all fields:

   simple-binding.aps:12:Warning: enclosing not declared either synthesized or inherited. Marking it as synthesized for now.

2. Extraneous warnings on all uses of non-phylum constructor arguments, e.g.

   simple-binding.aps:89:Warning: using a syntax decl

3. gets a type-3 circularity error

   local cycle (3) for variable involving <cond@144>

simple-binding.aps:160:Cycle detected (3); Attribute grammar is not OAG

The first two I have investigated to some extent and are caused by reordering of checks. The third may be caught up in the new scheduler.

[boyland]

Item #1 is resolved. #2 is harder. Just checking that teh RHS_DECL is not being handled as a PHYLUM is not enough. Even remote access is a problem, we don't want remote access to be used to access attributes. On the other hand, calling lineno on a syntax (or remote syntax) node is fine. Maybe lineno should be recast as an implicit attribute set by the defining module. This makes sense since lineno is not intrinsic to all tree modules.

[boyland]

In any case, aps-fiber is wrong place to put the warning since it will occur multiple times. It needs to go earlier, perhaps in aps-dnc.

[boyland]

DIscussed with Amir: he found that commit 'function formals should not be involved in a cycle' caused the regression #3 because it led to entity_used assignments to be done before it's ready.

Until this change, functions were treated like procedures and may need multiple passes, but this makes no sense for functions, so we got rid of the dependencies, which caused trying to schedule the function call to generate a cycle in the caller. More work is needed.

[amir734jj]

diff before after 
112a113
> 1- result$entity_used!
119,120c120
< 2- result$entity_used!
< 2+ es$entity_used!
---
> 1+ es$entity_used!
124a125
> 1- result$entity_used!
137,139c138,139
< 2- result$entity_used!
< 2+ scope$enclosing.entities.entity_used!
< 2+ scope$entities.entity_used!
---
> 1+ scope$enclosing.entities.entity_used!
> 1+ scope$entities.entity_used!

meld before after

left is before/right is after