Skip to content

Commit 66c413c

Browse files
committed
chore: cleanup
1 parent b346c26 commit 66c413c

File tree

7 files changed

+12
-13
lines changed

7 files changed

+12
-13
lines changed

src/main/java/net/bramp/ffmpeg/builder/AbstractFFmpegInputBuilder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import net.bramp.ffmpeg.probe.FFmpegProbeResult;
66

77
import javax.annotation.CheckReturnValue;
8-
import java.util.List;
98

109
public abstract class AbstractFFmpegInputBuilder<T extends AbstractFFmpegInputBuilder<T>> extends AbstractFFmpegStreamBuilder<T> {
1110
private final FFmpegProbeResult probeResult;

src/main/java/net/bramp/ffmpeg/builder/AbstractFFmpegOutputBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import net.bramp.ffmpeg.probe.FFmpegProbeResult;
2020

2121
/** Builds a representation of a single output/encoding setting */
22-
@SuppressWarnings({"DeprecatedIsStillUsed", "deprecation","unchecked"})
22+
@SuppressWarnings({"DeprecatedIsStillUsed", "unchecked"})
2323
public abstract class AbstractFFmpegOutputBuilder<T extends AbstractFFmpegOutputBuilder<T>> extends AbstractFFmpegStreamBuilder<T> {
2424

2525
static final Pattern trailingZero = Pattern.compile("\\.0*$");

src/main/java/net/bramp/ffmpeg/builder/FFmpegBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public String toString() {
4444
}
4545
}
4646

47-
/** Log level options: https://ffmpeg.org/ffmpeg.html#Generic-options */
47+
/** Log level options: <a href="https://ffmpeg.org/ffmpeg.html#Generic-options">ffmpeg documentation</a> */
4848
public enum Verbosity {
4949
QUIET,
5050
PANIC,

src/main/java/net/bramp/ffmpeg/builder/MetadataSpecifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
/**
1616
* Metadata spec, as described in the "map_metadata" section of
17-
* https://www.ffmpeg.org/ffmpeg-all.html#Main-options
17+
* <a href="https://www.ffmpeg.org/ffmpeg-all.html#Main-options">Main options</a>
1818
*/
1919
@Immutable
2020
public class MetadataSpecifier {

src/main/java/net/bramp/ffmpeg/builder/StreamSpecifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import static com.google.common.base.Preconditions.checkNotNull;
44
import static net.bramp.ffmpeg.builder.MetadataSpecifier.checkValidKey;
55

6-
/** https://ffmpeg.org/ffmpeg.html#Stream-specifiers */
6+
/** <a href="https://ffmpeg.org/ffmpeg.html#Stream-specifiers">Stream specifier</a> */
77
public class StreamSpecifier {
88

99
private final String spec;

src/test/java/net/bramp/ffmpeg/builder/FFmpegBuilderTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import static org.junit.Assert.assertEquals;
1313

1414
import com.google.common.collect.ImmutableList;
15-
import java.io.IOException;
1615
import java.net.URI;
1716
import java.util.List;
1817
import java.util.concurrent.TimeUnit;
@@ -26,9 +25,6 @@
2625

2726
@SuppressWarnings("unused")
2827
public class FFmpegBuilderTest {
29-
30-
public FFmpegBuilderTest() throws IOException {}
31-
3228
@Test
3329
public void testNormal() {
3430

src/test/java/net/bramp/ffmpeg/builder/FFmpegHlsOutputBuilderTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.google.common.collect.ImmutableList;
44

55
import java.nio.file.Files;
6+
import java.nio.file.Path;
67
import java.nio.file.Paths;
78
import java.util.concurrent.TimeUnit;
89

@@ -79,9 +80,12 @@ public void mixedHlsAndDefault() {
7980

8081
@Test
8182
public void testConvertVideoToHls() throws IOException {
83+
Path manifestFilePath = Paths.get("tmp/output.m3u8");
84+
Path segmentFilePath = Paths.get("tmp/file000.ts");
85+
8286
Files.createDirectories(Paths.get("tmp/"));
83-
Files.deleteIfExists(Paths.get("tmp/output.m3u8"));
84-
Files.deleteIfExists(Paths.get("tmp/file000.m3u8"));
87+
Files.deleteIfExists(manifestFilePath);
88+
Files.deleteIfExists(segmentFilePath);
8589

8690
List<String> command = new FFmpegBuilder()
8791
.setInput(Samples.TEST_PREFIX + Samples.base_big_buck_bunny_720p_1mb)
@@ -98,8 +102,8 @@ public void testConvertVideoToHls() throws IOException {
98102

99103
new FFmpeg().run(command);
100104

101-
assertTrue(Files.exists(Paths.get("tmp/output.m3u8")));
102-
assertTrue(Files.exists(Paths.get("tmp/file000.ts")));
105+
assertTrue(Files.exists(manifestFilePath));
106+
assertTrue(Files.exists(segmentFilePath));
103107
}
104108

105109
@Test

0 commit comments

Comments
 (0)