-
-
Notifications
You must be signed in to change notification settings - Fork 423
FFmpegBuilder to parse the full ffmpeg command string #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I guess if you just want a normal command line string, why not invoke ProcessBuilder directly? I think the purpose of the library is to construct the command line string. However, I'm happy to understand the use case more. |
Sure. I have a service that runs these commands in separate threads and these commands are configurable by users. so I'd like to validate ffmepg arguments first and make sure that the command is valid to prevent arbitrary code execution. |
friendly ping, any thoughts? |
Sorry for the late update: The way we and ffmpeg handle parameters makes this extremely hard. We don't implement all existing options (not all documented default options). Currently, inputs are only partially supported, there not handled in the correct way. But even if we would handle them according to the specification, given a ffmpeg command like this: More severe: Last: There is no existing code for us to perform a reverse mapping. This would essentially double our mappings, as we would have to do them both ways and add all the synonyms ffmpeg supports on top of that. I would love to implement this over our existing serialization method, but we must rewrite much of our internal handling. We can approach a minimal version (without extra args) after #318 if you're still interested in this. |
Is your feature request related to a problem? Please describe.
There is a wiki that shows examples of how to convert a ffmpeg command string to FFmpegBuilder instance. So it seems like many people have trouble converting some of the commands.
Describe the solution you'd like
It would be extremely helpful and useful if FFmpegBuilder can parse a ffmpeg command string and turn it to a FFmpeg instance. This would make this library a lot easier to use and more useful IMO.
The text was updated successfully, but these errors were encountered: