Skip to content

Commit f9a3330

Browse files
committed
replace request with fetch in brave ads resources script
1 parent d23ad4a commit f9a3330

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

scripts/generateBraveAdsResourcesComponentInputFiles.js

+15-18
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
const path = require('path')
66
const mkdirp = require('mkdirp')
77
const fs = require('fs-extra')
8-
const request = require('request')
98
const commander = require('commander')
9+
const { Readable } = require('stream')
10+
const { finished } = require('stream/promises')
1011

1112
const getComponentList = () => {
1213
return [
@@ -79,19 +80,15 @@ const getComponentList = () => {
7980
function downloadComponentInputFiles (manifestFileName, manifestUrl, outDir) {
8081
return new Promise(function (resolve, reject) {
8182
let manifestBody = '{}'
82-
request(manifestUrl, async function (error, response, body) {
83-
if (error) {
84-
console.error(`Error from ${manifestUrl}:`, error)
85-
return reject(error)
86-
}
87-
88-
if (response && response.statusCode === 200) {
89-
manifestBody = body
83+
fetch(manifestUrl, async function (response) {
84+
if (response.status === 200) {
85+
manifestBody = await response.text()
9086
}
9187

9288
const manifestJson = JSON.parse(manifestBody)
9389
if (!manifestJson.schemaVersion) {
94-
console.error('Error: Missing schema version')
90+
const error = 'Error: Missing schema version'
91+
console.error(error)
9592
return reject(error)
9693
}
9794

@@ -105,20 +102,20 @@ function downloadComponentInputFiles (manifestFileName, manifestUrl, outDir) {
105102
})
106103
}
107104

108-
const downloadOps = fileList.map((fileName) => new Promise(resolve => {
105+
const downloadOps = fileList.map(async (fileName) => {
109106
const resourceFileOutPath = path.join(outDir, fileName)
110107
const resourceFileUrl = new URL(fileName, manifestUrl).href
111-
request(resourceFileUrl)
112-
.pipe(fs.createWriteStream(resourceFileOutPath))
113-
.on('finish', () => {
114-
console.log(resourceFileUrl)
115-
resolve()
116-
})
117-
}))
108+
const response = await fetch(resourceFileUrl)
109+
const ws = fs.createWriteStream(resourceFileOutPath)
110+
return finished(Readable.fromWeb(response.body).pipe(ws))
111+
.then(() => console.log(resourceFileUrl))
112+
})
118113

119114
await Promise.all(downloadOps)
120115

121116
resolve()
117+
}).catch(error => {
118+
throw new Error(`Error from ${manifestUrl}: ${error.cause}`)
122119
})
123120
})
124121
}

0 commit comments

Comments
 (0)