Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding hardcoded -B values is possible from command line #92

Open
edawson opened this issue Feb 12, 2024 · 3 comments
Open

Overriding hardcoded -B values is possible from command line #92

edawson opened this issue Feb 12, 2024 · 3 comments

Comments

@edawson
Copy link

edawson commented Feb 12, 2024

Hi @brentp ,

While testing this, I noticed that it's possible to pass -B <N> at the command line and override the -B 2 value set in bwa-meth.py. Is this intended behavior to allow users to override -B, or should it always be fixed to -B 2 for things to properly function?

Thanks,
Eric

@brentp
Copy link
Owner

brentp commented Feb 12, 2024

Hi Eric,
I don't really remember why that's there, but is it a problem to allow a user to set it?
I guess it could mess up other thresholds if other penalties/scores are not modified?

@edawson
Copy link
Author

edawson commented Feb 13, 2024

I don't know enough about the flag to know for sure; just wanted to clarify the intended behavior. I think it's even possible to pass -B multiple times and override the user override.

It might be clearer to add -B to the argparse arguments with a default of 2 and a single int value as input?

@brentp
Copy link
Owner

brentp commented Feb 13, 2024

is there a "not" missing from your original issue? I don't see how it's possible to set -B:
https://github.com/brentp/bwa-meth/blob/master/bwameth.py#L358-L361

are you asking to make that available? I'd rather not unless you have compelling reason especially since bwa-meth has been unchanged for so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants