Segmentation Fault on ruby 2.7

[andy-ganchrow]

With yajl-ruby-1.4.1

Over the last week we have been experiencing a, for lack of a better word, massive issue with ruby applications just crashing intermittently

The backtrace ultimately points to the Hash#to_json, created from requiring yajl/json_gem

Removing all instances of the yajl/json_gem in favor of the json library fixed the issue, but not until today did I come up with a somewhat simple script to reproduce the same crash report

For Ubuntu 20.04, The following works on ruby2.6, but fails on 2.7.0, 2.7.2, and sometimes on 2.7.1

require 'yajl/json_gem'
a = 10000.times.map { |x| { a: 5, 1 => 'foo', b: [1, 2, 3] } }
a.each { |b| b.to_json }

require 'yajl/json_gem'
a = 10000.times.map { |x| {} }
a.each { |b| b.to_json }

No issues at all with any of the above on Ubuntu 20.10, which is an indicator its a libyaml or libjson library

Its worth noting the following does not fail ( or at least immediate enough for me to notice )

require 'yajl/json_gem'
a = 1000.times.map { |x| {} }
a.each { |b| b.to_json }

And a version that does not assign a variable but loops 10000 times does not fail either

require 'yajl/json_gem'
10000.times.each { |x| {}.to_json }

The crash report is below, and immediately what stands out to me is the backtrace appears to suggest an on_progress_callback is provided to the to_json method, which obviously its not

Let me know and I'll try to provide the differences in the installed libs on 20.10 and 20.04

https://pastebin.com/fZq0iKMQ

[amymsahli]

We are seeing this exact issue as well with Ruby 2.7.2 and Ubuntu 20.04. We will be trying to remove the yajl/json_gem also. :(

[markdascher]

This is caused by a missing RB_GC_GUARD combined with some more aggressive gcc optimizations. -fno-caller-saves seems to help sometimes, but I think that's just lucky register shuffling. The same flag could just as easily make things worse.

At the very least, this return statement needs to be split up, to insert RB_GC_GUARD(rb_encoder); after the rb_yajl_encoder_encode call:

yajl-ruby/ext/yajl/yajl_ext.c

Lines 32 to 39 in e8de283

	#define YAJL_RB_TO_JSON \
	VALUE rb_encoder, cls; \
	rb_scan_args(argc, argv, "01", &rb_encoder); \
	cls = rb_obj_class(rb_encoder); \
	if (rb_encoder == Qnil || cls != cEncoder) { \
	rb_encoder = rb_yajl_encoder_new(0, NULL, cEncoder); \
	} \
	return rb_yajl_encoder_encode(1, &self, rb_encoder); \

But there could be other spots too. The whole situation feels like a mess. Maybe the real lesson is to just avoid native extensions.