Skip to content

HTML Safe is the opposite of rails convention #210

@SampsonCrowley

Description

@SampsonCrowley

Now, I'm very aware this is not a Rails gem; but what you've called the html_safe flag, even though your usage is much more accurate to the name of the flag (and while I also hate the way the rails guys named that one in particular), I think you could take a page from the rails book there. The rails convention is everything not flagged should be escaped, and adding html_safe means you've already escaped and cleared it.

The same concepts maybe don't apply here because it's a JSON library; but just food for thought

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions