Adopt the new shellcheck warnings numbers (#146)

* shellcheck: disable function names with -
* shellcheck: disable warning while using 'local'
* shellcheck: fix more warnings
* vnet-start: fix an error message
* shellcheck: fix pipefail warning
* shellcheck: fix shubshell related warnings

Author: pizzamig

share/pot/add-dep.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 :
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 add-dep-help()
 {
 	echo "pot add-dep [-hv] -p pot -P depPot"
@@ -15,18 +15,18 @@ add-dep-help()
 # $2 depPot
 _add_dependency()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _depPot _pname _cdir
 	_pname="$1"
 	_depPot="$2"
 	_cdir=$POT_FS_ROOT/jails/$_pname/conf
 	echo "pot.depend=$_depPot" >> "$_cdir"/pot.conf
 }
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 pot-add-dep()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _depPot
 	_depPot=
 	_pname=

share/pot/clone-fscomp.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 :
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 clone-fscomp-help()
 {
 	echo "pot clone-fscomp [-hv] -f fscomp -F fscomp"
@@ -15,7 +15,7 @@ clone-fscomp-help()
 # $2 old fscomp name
 _cf_zfs()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _fscomp _cfscomp _fsdset _fsdir _snap
 	_fscomp=$1
 	_cfscomp=$2
@@ -32,10 +32,10 @@ _cf_zfs()
 	return 0 # true
 }
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 pot-clone-fscomp()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _fscomp _cfscomp
 	_fscomp=
 	_cfscomp=

share/pot/clone.sh

@@ -4,7 +4,7 @@
 trap _cj_undo_clone TERM INT
 _set_pipefail
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 clone-help()
 {
 	echo "pot clone [-hvF] -p potname -P basepot [-i ipaddr]"
@@ -44,7 +44,7 @@ _cj_undo_clone()
 # $4 custom snapshot tag
 _cj_zfs()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _potbase _jdset _pdir _pbdir _pbdset _mnt_p _opt _autosnap _snaptag _pb_type _snap __last_snap
 	_pname=$1
 	_potbase=$2
@@ -179,7 +179,7 @@ _cj_zfs()
 # $6 network stack
 _cj_conf()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _potbase _ip _network_type _bridge_name _stack
 	_pname=$1
 	_potbase=$2
@@ -233,10 +233,10 @@ _cj_conf()
 	fi
 }
 
-# shellcheck disable=SC2039
+# shellcheck disable=SC3033
 pot-clone()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _ipaddr _potbase _pblvl _autosnap _pb_type _pb_network_type _network_type _bridge_name _network_stack _snap _flv
 	_pname=
 	_ipaddr=

share/pot/common-flv.sh

@@ -5,7 +5,7 @@
 # $2 : the set-cmd line in the file
 _flv_set_cmd()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _line _cmd
 	_pname="$1"
 	_line="$2"
@@ -19,7 +19,7 @@ _flv_set_cmd()
 
 _exec_flv()
 {
-	# shellcheck disable=SC2039
+	# shellcheck disable=SC3043
 	local _pname _flv _pdir
 	_pname=$1
 	_flv=$2