Fetch base in cache (#147)

* Store base.txz in POT_CACHE instead of /tmp
* tests: fix fetch related tests

Author: pizzamig

CHANGELOG.md

@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - info: -B instead of -b for private bridge information
 - copy-in: copy is executed in the jail environment, to avoid soft-link related issues in the destination path
 - copy-in: with running pots, a -F flag is needed to force the copy, an operation that is discouraged for security reasons
+- fetch base.txz: the base FreeBSD tarball used to be temporarily stored in /tmp. While a POT_CACHE folder is available, use that instead.
 
 ### Removed
 - create-dns: remove this already deprecated command, leaving the user to create a dns for the public bridge

share/pot/common.sh

@@ -855,7 +855,7 @@ _fetch_freebsd()
 	if ! _fetch_freebsd_internal "$1" "$_archpath"; then
 		# remove artifact and retry only once
 		_rel="$( _get_freebsd_release_name "$1" )"
-		rm -f /tmp/"${_rel}"_base.txz
+		rm -f "${POT_CACHE}/${_rel}"_base.txz
 		if ! _fetch_freebsd_internal "$1" "$_archpath"; then
 			return 1 # false
 		fi
@@ -872,15 +872,15 @@ _fetch_freebsd_internal()
 	_rel="$( _get_freebsd_release_name "$1" )"
 	_archpath="$( echo "$2" | sed -e 's:-:/:' )"
 
-	if [ ! -r /tmp/"${_rel}"_base.txz ]; then
-		fetch -m https://ftp.freebsd.org/pub/FreeBSD/releases/"$_archpath"/"${_rel}"/base.txz -o /tmp/"${_rel}"_base.txz
+	if [ ! -r "${POT_CACHE}/${_rel}"_base.txz ]; then
+		fetch -m https://ftp.freebsd.org/pub/FreeBSD/releases/"$_archpath"/"${_rel}"/base.txz -o "${POT_CACHE}/${_rel}"_base.txz
 	fi
 
-	if [ ! -r /tmp/"${_rel}"_base.txz ]; then
+	if [ ! -r "${POT_CACHE}/${_rel}"_base.txz ]; then
 		return 1 # false
 	fi
 	if [ -r /usr/local/share/freebsd/MANIFESTS/"$2"-"${_rel}" ]; then
-		_sha=$( sha256 -q /tmp/"${_rel}"_base.txz )
+		_sha=$( sha256 -q "${POT_CACHE}/${_rel}"_base.txz )
 		# shellcheck disable=SC2002
 		_sha_m=$( cat /usr/local/share/freebsd/MANIFESTS/"$2"-"${_rel}" | awk '/^base.txz/ { print $2 }' )
 		# This version would remove the useless cat, but the testability of this function is compromised

share/pot/create-base.sh

@@ -58,7 +58,7 @@ _cb_tar_dir()
 	(
 		set -e
 		cd "$_mnt"
-		tar xkf /tmp/"${_rel}"_base.txz
+		tar xkf "${POT_CACHE}/${_rel}"_base.txz
 		# add release information
 		echo "$_rel" > .osrelease
 		cp -a root opt/custom/

share/pot/create.sh

@@ -435,16 +435,16 @@ _cj_single_install()
 	else
 		_rel="$_base"-RELEASE
 	fi
-	if [ ! -r "/tmp/${_rel}_base.txz" ]; then
-		_error "FreeBSD base tarball /tmp/${_rel}_base.txz is missing"
+	if [ ! -r "${POT_CACHE}/${_rel}_base.txz" ]; then
+		_error "FreeBSD base tarball ${POT_CACHE}/${_rel}_base.txz is missing"
 		_cj_undo_create
 		return 1 # falase
 	fi
 	(
 	  set -e
 	  cd "$_proot"
 	  _info "Extract the tarball"
-	  tar xkf "/tmp/${_rel}_base.txz"
+	  tar xkf "${POT_CACHE}/${_rel}_base.txz"
 	  if [ ! -d usr/home ]; then
 		  mkdir -p usr/home
 	  fi

tests/common5.sh

@@ -207,6 +207,7 @@ setUp()
 	__arch="amd64"
 	__didfetch="1"
 	common_setUp
+	POT_CACHE="/tmp"
 	FETCH_CALLS=0
 	RM_CALLS=0
 }