Skip to content

Fix ARC broadcast to return error for double spend and orphan transactions #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ty-everett merged 2 commits into from
Feb 3, 2026
Merged

Fix ARC broadcast to return error for double spend and orphan transactions #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d39a12
Fixed issue #105
Stephen-Thomson Jan 21, 2026
3259ec2
Merge branch 'master' into Issue_105
ty-everett Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/transaction/broadcasters/ARC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,33 @@ export default class ARC implements Broadcaster {
)
if (response.ok) {
const { txid, extraInfo, txStatus, competingTxs } = response.data

// Check for error txStatus values that ARC returns with HTTP 200
// These should be treated as broadcast failures
const errorStatuses = [
'DOUBLE_SPEND_ATTEMPTED',
'REJECTED',
'INVALID',
'MALFORMED',
'MINED_IN_STALE_BLOCK'
]

const isOrphan = extraInfo?.toUpperCase().includes('ORPHAN') ||
txStatus?.toUpperCase().includes('ORPHAN')

if (errorStatuses.includes(txStatus?.toUpperCase()) || isOrphan) {
const failure: BroadcastFailure = {
status: 'error',
code: txStatus ?? 'UNKNOWN',
txid,
description: `${txStatus ?? ''} ${extraInfo ?? ''}`.trim()
}
if (competingTxs != null) {
failure.more = { competingTxs }
}
return failure
}

const broadcastRes: BroadcastResponse = {
status: 'success',
txid,
Expand Down
98 changes: 98 additions & 0 deletions src/transaction/broadcasters/__tests/ARC.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,104 @@ describe('ARC Broadcaster', () => {
}
})

it('should return error for DOUBLE_SPEND_ATTEMPTED even with HTTP 200', async () => {
const mockFetch = mockedFetch({
status: 200,
data: {
txid: '89100426fc13a55260fa65e621e7591f8b01007af62480e818d0da518723bfd3',
txStatus: 'DOUBLE_SPEND_ATTEMPTED',
extraInfo: '',
competingTxs: ['5e58f06a83343011f77d9109aab08dcc38d89e8cc7bd55da16affa948281d7ed']
}
})

const broadcaster = new ARC(URL, {
httpClient: new FetchHttpClient(mockFetch)
})
const response = await broadcaster.broadcast(transaction)

expect(mockFetch).toHaveBeenCalled()
expect(response.status).toBe('error')
if (response.status === 'error') {
expect(response.code).toBe('DOUBLE_SPEND_ATTEMPTED')
expect(response.txid).toBe('89100426fc13a55260fa65e621e7591f8b01007af62480e818d0da518723bfd3')
expect(response.more).toEqual({
competingTxs: ['5e58f06a83343011f77d9109aab08dcc38d89e8cc7bd55da16affa948281d7ed']
})
}
})

it('should return error for SEEN_IN_ORPHAN_MEMPOOL even with HTTP 200', async () => {
const mockFetch = mockedFetch({
status: 200,
data: {
txid: 'b06cb1059c2bf3debee1e65dc90d0815653325c7cf2584763b90c761c09919db',
txStatus: 'success',
extraInfo: 'SEEN_IN_ORPHAN_MEMPOOL'
}
})

const broadcaster = new ARC(URL, {
httpClient: new FetchHttpClient(mockFetch)
})
const response = await broadcaster.broadcast(transaction)

expect(mockFetch).toHaveBeenCalled()
expect(response.status).toBe('error')
if (response.status === 'error') {
expect(response.code).toBe('success')
expect(response.txid).toBe('b06cb1059c2bf3debee1e65dc90d0815653325c7cf2584763b90c761c09919db')
expect(response.description).toContain('ORPHAN')
}
})

it('should return error for REJECTED status even with HTTP 200', async () => {
const mockFetch = mockedFetch({
status: 200,
data: {
txid: 'abc123',
txStatus: 'REJECTED',
extraInfo: 'Transaction rejected by network'
}
})

const broadcaster = new ARC(URL, {
httpClient: new FetchHttpClient(mockFetch)
})
const response = await broadcaster.broadcast(transaction)

expect(mockFetch).toHaveBeenCalled()
expect(response.status).toBe('error')
if (response.status === 'error') {
expect(response.code).toBe('REJECTED')
expect(response.description).toContain('REJECTED')
expect(response.description).toContain('Transaction rejected by network')
}
})

it('should still return success for valid txStatus values', async () => {
const mockFetch = mockedFetch({
status: 200,
data: {
txid: 'valid_txid',
txStatus: 'SEEN_ON_NETWORK',
extraInfo: 'Transaction accepted'
}
})

const broadcaster = new ARC(URL, {
httpClient: new FetchHttpClient(mockFetch)
})
const response = await broadcaster.broadcast(transaction)

expect(mockFetch).toHaveBeenCalled()
expect(response.status).toBe('success')
if (response.status === 'success') {
expect(response.txid).toBe('valid_txid')
expect(response.message).toBe('SEEN_ON_NETWORK Transaction accepted')
}
})

function mockedFetch (response: { status: number, data: any }): jest.Mock {
return jest.fn().mockResolvedValue({
ok: response.status === 200,
Expand Down