Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer RNEA.from(Readonly)Array #60

Open
Tracked by #475
thewilkybarkid opened this issue Feb 8, 2021 · 2 comments
Open
Tracked by #475

Prefer RNEA.from(Readonly)Array #60

thewilkybarkid opened this issue Feb 8, 2021 · 2 comments

Comments

@thewilkybarkid
Copy link

Thanks for the plugin, learnt a couple of things already with it.

O.fromPredicate((array) => array.length > 0) could be replaced with RNEA.fromArray/RNEA.fromReadonlyArray (found a few usages in sciety/sciety@103fe14).
@thewilkybarkid
Copy link
Author

Maybe the rule should be 'prefer constructor' (combining with #61 and similar).

@thewilkybarkid thewilkybarkid mentioned this issue Feb 17, 2021
Closed
2 tasks
@thewilkybarkid
Copy link
Author

O.filter((array) => array.length > 0) should be covered too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid