Skip to content

Commit 0d7f0fc

Browse files
committed
grammar tweaks
Signed-off-by: Joel Dice <[email protected]>
1 parent de65ce5 commit 0d7f0fc

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

accepted/component-model-async.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -212,13 +212,14 @@ neither of those methods allow guest-level concurrency, so they would only make
212212
sense in cases where the host can complete the task without blocking or
213213
`await`ing.
214214

215-
For the above reasons, I propose that, once the `component-async` feature
216-
is enabled by default, we _deprecate_ `func_wrap_async` and modify the
217-
`bindgen!` macro to stop using it by default (but still allow opting in to it
218-
via an option during the deprecation period). Rationale: host functions which
219-
need to `await` must account for the possibility the it has been called via an
220-
async-lowered import and thus should not block the host _or_ the guest. And
221-
host functions which are non-blocking might as well use plain old `func_wrap`.
215+
For the above reasons, I propose that, once the `component-async` feature is
216+
enabled by default, we _deprecate_ `func_wrap_async` and modify the `bindgen!`
217+
macro to stop using it by default (but still allow opting in to it via an option
218+
during the deprecation period). Rationale: a host function which needs to
219+
`await` must account for the possibility the it has been called via an
220+
async-lowered import and thus should not block the host _or_ the guest.
221+
Conversely, a host function which is always non-blocking might as well use plain
222+
old `func_wrap`.
222223

223224
On the other hand, there's no particular reason to deprecate `call_async`, which
224225
may be more convenient than `call_concurrent` when the embedder only needs to

0 commit comments

Comments
 (0)