Fixed chart height determination issue number 2467 (#2541)

craigloewen-msft · kt3k · commit 89ef1088421e · 2018-12-08T21:27:00.000+09:00
* Fixed chart height determination issue number 2467

* Added sample resize.html
diff --git a/htdocs/samples/resize.html b/htdocs/samples/resize.html
@@ -0,0 +1,50 @@
+<html>
+
+<head>
+    <link href="../css/c3.css" rel="stylesheet" type="text/css">
+    <style>
+        .chartcontainer {
+            background-color: #EEE;
+            height: 80%;
+            width: 90%;
+            border: 1px solid black;
+        }
+
+        #chart {
+            height: 100%;
+        }
+    </style>
+</head>
+
+<body>
+    <h3>Please drag the window around to watch the chart resize.</h3>
+    <div class="chartContainer">
+        <div id="chart"></div>
+
+    </div>
+
+    <script src="https://d3js.org/d3.v5.min.js" charset="utf-8"></script>
+    <script src="../js/c3.js"></script>
+    <script>
+        var chart = c3.generate({
+            data: {
+                bindto: '#chart',
+                columns: [
+                    ['data1', 30, 200, 100, 400, 150, 250],
+                    ['data2', 130, 100, 140, 200, 150, 50]
+                ],
+                types: {
+                    data1: 'spline',
+                    data2: 'spline'
+                }
+            },
+            spline: {
+                interpolation: {
+                    type: 'monotone', // 'cardinal' is default
+                },
+            },
+        });
+    </script>
+</body>
+
+</html>
diff --git a/src/core.js b/src/core.js
@@ -919,8 +919,6 @@ ChartInternal.prototype.updateSvgSize = function() {
     $$.svg.select('#' + $$.clipIdForSubchart).select('rect')
         .attr('width', $$.width)
         .attr('height', brush.size() ? brush.attr('height') : 0);
-    // MEMO: parent div's height will be bigger than svg when <!DOCTYPE html>
-    $$.selectChart.style('max-height', $$.currentHeight + "px");
 };
 
 ChartInternal.prototype.updateDimension = function(withoutAxis) {
diff --git a/src/size.js b/src/size.js
@@ -73,8 +73,7 @@ ChartInternal.prototype.getParentWidth = function () {
     return this.getParentRectValue('width');
 };
 ChartInternal.prototype.getParentHeight = function () {
-    var h = this.selectChart.style('height');
-    return h.indexOf('px') > 0 ? +h.replace('px', '') : 0;
+    return this.getParentRectValue('height');
 };
 
 
