fix uts

Author: taylanisikdemir

common/persistence/sql/sql_execution_store_test.go

@@ -2881,14 +2881,14 @@ func TestGetHistoryTasks_SQL(t *testing.T) {
 					{
 						ShardID:             shardID,
 						TaskID:              10,
-						VisibilityTimestamp: time.Unix(1, 1),
+						VisibilityTimestamp: time.Unix(1, 1).UTC(),
 						Data:                []byte(`{"task": "timer"}`),
 						DataEncoding:        "json",
 					},
 					{
 						ShardID:             shardID,
 						TaskID:              101,
-						VisibilityTimestamp: time.Unix(1, 1),
+						VisibilityTimestamp: time.Unix(1, 1).UTC(),
 						Data:                []byte(`{"task": "timer"}`),
 						DataEncoding:        "json",
 					},
@@ -2906,7 +2906,7 @@ func TestGetHistoryTasks_SQL(t *testing.T) {
 					EventID: 100,
 					TaskData: persistence.TaskData{
 						TaskID:              10,
-						VisibilityTimestamp: time.Unix(1, 1),
+						VisibilityTimestamp: time.Unix(1, 1).UTC(),
 					},
 				},
 			},

common/resource/resource_impl_test.go

@@ -211,7 +211,6 @@ func TestStartStop(t *testing.T) {
 	// validations
 	assert.Equal(t, serviceName, i.GetServiceName())
 	assert.Equal(t, selfHostInfo, i.GetHostInfo())
-	assert.Equal(t, params.ClusterMetadata, i.GetClusterMetadata())
 	gotDomain, err := i.GetDomainCache().GetDomainByID("test-domain-id")
 	assert.NoError(t, err)
 	assert.Equal(t, domain.Info, gotDomain.GetInfo())

common/testing/allisset.go

@@ -37,6 +37,6 @@ func allIsSet(t *testing.T, err error) {
 		field := errValue.Field(i)
 
 		// IsZero checks if the value is the default value (e.g. nil, "", 0 etc)
-		assert.True(t, !field.IsZero(), "Field %s is not set", errValue.Type().Field(i).Name)
+		assert.True(t, !field.IsZero(), "Field %s is not set for error %s", errValue.Type().Field(i).Name, errValue.Type())
 	}
 }

common/types/testdata/error.go

@@ -60,11 +60,13 @@ var (
 		DomainName:     DomainName,
 		CurrentCluster: ClusterName1,
 		ActiveCluster:  ClusterName2,
+		ActiveClusters: []string{ClusterName2},
 	}
 	EntityNotExistsError = types.EntityNotExistsError{
 		Message:        ErrorMessage,
 		CurrentCluster: ClusterName1,
 		ActiveCluster:  ClusterName2,
+		ActiveClusters: []string{ClusterName2},
 	}
 	WorkflowExecutionAlreadyCompletedError = types.WorkflowExecutionAlreadyCompletedError{
 		Message: ErrorMessage,

service/history/engine/engineimpl/register_domain_failover_callback_test.go

@@ -160,7 +160,7 @@ func TestGenerateFailoverTasksForDomainCallback(t *testing.T) {
 
 			cluster := cluster.NewMetadata(
 				config.ClusterGroupMetadata{
-					FailoverVersionIncrement: 1,
+					FailoverVersionIncrement: 10,
 					PrimaryClusterName:       "cluster0",
 					CurrentClusterName:       "cluster0",
 					ClusterGroup: map[string]config.ClusterInformation{
@@ -585,7 +585,7 @@ func TestDomainCallback(t *testing.T) {
 
 			cluster := cluster.NewMetadata(
 				config.ClusterGroupMetadata{
-					FailoverVersionIncrement: 1,
+					FailoverVersionIncrement: 10,
 					PrimaryClusterName:       "cluster0",
 					CurrentClusterName:       "cluster0",
 					ClusterGroup: map[string]config.ClusterInformation{
@@ -636,7 +636,7 @@ func TestDomainLocking(t *testing.T) {
 
 	cluster := cluster.NewMetadata(
 		config.ClusterGroupMetadata{
-			FailoverVersionIncrement: 1,
+			FailoverVersionIncrement: 10,
 			PrimaryClusterName:       "cluster0",
 			CurrentClusterName:       "cluster0",
 			ClusterGroup: map[string]config.ClusterInformation{

service/history/engine/engineimpl/reset_workflow_execution_test.go

@@ -345,7 +345,7 @@ func TestResetWorkflowExecution(t *testing.T) {
 				},
 			},
 			expectedErr: &types.BadRequestError{
-				Message: "workflow is not resettable. Error: fail to get cluster name for failover version: failed to resolve failover version: could not resolve failover version: 1004",
+				Message: "workflow is not resettable. Error: fail to get cluster name for failover version: failed to resolve failover version to a cluster: could not resolve failover version: 1004",
 			},
 		},
 		{