refactor: remove dynamicTheme prop

Author: adrcotfas

src/core/PaperProvider.tsx

@@ -12,11 +12,6 @@ import { useSystemColorScheme } from './useSystemColorScheme';
 import MaterialCommunityIcon from '../components/MaterialCommunityIcon';
 import PortalHost from '../components/Portal/PortalHost';
 import { ReduceMotionContext } from '../theme/accessibility/ReduceMotionContext';
-import {
-  isDynamicColorSupported,
-  lightDynamicColors,
-  darkDynamicColors,
-} from '../theme/schemes/DynamicTheme';
 import type { ThemeProp } from '../types';
 
 export type Props = {
@@ -25,33 +20,26 @@ export type Props = {
   settings?: Settings;
   direction?: Direction;
   reduceMotion?: ReduceMotionPreference;
-  dynamicColor?: boolean;
 };
 
 const PaperProvider = (props: Props) => {
-  const { reduceMotion = 'auto', dynamicColor = false } = props;
+  const { reduceMotion = 'auto' } = props;
 
   const colorScheme = useSystemColorScheme(!props.theme);
   const resolvedReduceMotion = useResolvedReduceMotion(reduceMotion);
 
   const theme = React.useMemo(() => {
     const isDark = props.theme?.dark ?? colorScheme === 'dark';
     const base = defaultThemes[isDark ? 'dark' : 'light'];
-    const dynamicColors =
-      dynamicColor && isDynamicColorSupported
-        ? isDark
-          ? darkDynamicColors
-          : lightDynamicColors
-        : undefined;
     const scale = resolvedReduceMotion ? 0 : props.theme?.animation?.scale ?? 1;
 
     return {
       ...base,
       ...props.theme,
-      colors: { ...base.colors, ...props.theme?.colors, ...dynamicColors },
+      colors: { ...base.colors, ...props.theme?.colors },
       animation: { ...props.theme?.animation, scale },
     };
-  }, [colorScheme, props.theme, resolvedReduceMotion, dynamicColor]);
+  }, [colorScheme, props.theme, resolvedReduceMotion]);
 
   const { children, settings } = props;
 

src/core/__tests__/PaperProvider.test.tsx

@@ -9,7 +9,7 @@ import {
 import { render, act } from '@testing-library/react-native';
 
 import { useReduceMotion } from '../../theme/accessibility/ReduceMotionContext';
-import { LightTheme, DarkTheme } from '../../theme/schemes';
+import { DarkTheme, DynamicLightTheme, LightTheme } from '../../theme/schemes';
 import type { ThemeProp } from '../../types';
 import PaperProvider from '../PaperProvider';
 import { useTheme } from '../theming';
@@ -213,17 +213,10 @@ describe('PaperProvider', () => {
     ).toStrictEqual(0);
   });
 
-  it('leaves theme.colors unchanged when dynamicColor is true on an unsupported platform', async () => {
-    mockAppearance();
-    const { getByTestId } = render(
-      <PaperProvider dynamicColor>
-        <FakeChild />
-      </PaperProvider>
-    );
-    // `isDynamicColorSupported` is false on the test platform → no color override.
-    expect(getByTestId('provider-child-view').props.theme.colors.primary).toBe(
-      LightTheme.colors.primary
-    );
+  it('DynamicLightTheme falls back to LightTheme on unsupported platforms', () => {
+    // On non-Android (and Android API <31), DynamicLightTheme is structurally
+    // identical to LightTheme, so consumers can import it unconditionally.
+    expect(DynamicLightTheme.colors).toStrictEqual(LightTheme.colors);
   });
 
   it('should set Appearance listeners, if there is no theme', async () => {

src/theme/schemes/DynamicTheme.android.tsx

@@ -473,8 +473,12 @@ function buildDynamicColors(scheme: 'light' | 'dark'): Partial<ThemeColors> {
 
 export const isDynamicColorSupported = apiLevel >= 31;
 
-export const lightDynamicColors = buildDynamicColors('light');
-export const darkDynamicColors = buildDynamicColors('dark');
+const lightDynamicColors = isDynamicColorSupported
+  ? buildDynamicColors('light')
+  : undefined;
+const darkDynamicColors = isDynamicColorSupported
+  ? buildDynamicColors('dark')
+  : undefined;
 
 export const DynamicLightTheme: Theme = {
   ...LightTheme,

src/theme/schemes/DynamicTheme.tsx

@@ -1,8 +1,2 @@
-import type { ThemeColors } from '../types/color';
-
 export { DarkTheme as DynamicDarkTheme } from './DarkTheme';
 export { LightTheme as DynamicLightTheme } from './LightTheme';
-
-export const isDynamicColorSupported = false;
-export const lightDynamicColors: Partial<ThemeColors> = {};
-export const darkDynamicColors: Partial<ThemeColors> = {};