feat: make groupIdentifier required

Author: V3RON

plugin/src/features/ios/eas/index.ts

@@ -5,7 +5,7 @@ import { addApplicationGroupsEntitlement, getWidgetExtensionEntitlements } from
 export interface ConfigureEasBuildProps {
   bundleIdentifier: string
   targetName: string
-  groupIdentifier?: string
+  groupIdentifier: string
 }
 
 /**

plugin/src/features/ios/files/entitlements.ts

@@ -9,23 +9,21 @@ import { logger } from '../../../utils'
  */
 export function addApplicationGroupsEntitlement(
   entitlements: Record<string, any>,
-  groupIdentifier?: string
+  groupIdentifier: string
 ): Record<string, any> {
-  if (groupIdentifier) {
-    const existingApplicationGroups = (
-      (entitlements['com.apple.security.application-groups'] as string[]) ?? []
-    ).filter(Boolean)
+  const existingApplicationGroups = (
+    (entitlements['com.apple.security.application-groups'] as string[]) ?? []
+  ).filter(Boolean)
 
-    entitlements['com.apple.security.application-groups'] = [groupIdentifier, ...existingApplicationGroups]
-  }
+  entitlements['com.apple.security.application-groups'] = [groupIdentifier, ...existingApplicationGroups]
 
   return entitlements
 }
 
 /**
  * Gets the entitlements for the widget extension.
  */
-export function getWidgetExtensionEntitlements(groupIdentifier?: string): Record<string, any> {
+export function getWidgetExtensionEntitlements(groupIdentifier: string): Record<string, any> {
   const entitlements: Record<string, any> = {}
   addApplicationGroupsEntitlement(entitlements, groupIdentifier)
   return entitlements
@@ -34,7 +32,7 @@ export function getWidgetExtensionEntitlements(groupIdentifier?: string): Record
 export interface GenerateEntitlementsOptions {
   targetPath: string
   targetName: string
-  groupIdentifier?: string
+  groupIdentifier: string
 }
 
 /**

plugin/src/features/ios/files/index.ts

@@ -11,7 +11,7 @@ import { generateSwiftFiles } from './swift'
 export interface GenerateWidgetExtensionFilesProps {
   targetName: string
   widgets?: WidgetConfig[]
-  groupIdentifier?: string
+  groupIdentifier: string
 }
 
 /**

plugin/src/features/ios/index.ts

@@ -12,7 +12,7 @@ export interface WithIOSProps {
   bundleIdentifier: string
   deploymentTarget: string
   widgets?: WidgetConfig[]
-  groupIdentifier?: string
+  groupIdentifier: string
 }
 
 /**

plugin/src/features/ios/plist/index.ts

@@ -5,7 +5,7 @@ import { join as joinPath } from 'path'
 
 export interface ConfigureMainAppPlistProps {
   targetName: string
-  groupIdentifier?: string
+  groupIdentifier: string
 }
 
 /**
@@ -42,9 +42,7 @@ export const configureMainAppPlist: ConfigPlugin<ConfigureMainAppPlistProps> = (
         },
       ]
 
-      if (groupIdentifier) {
-        ;(content as any)['Voltra_AppGroupIdentifier'] = groupIdentifier
-      }
+      ;(content as any)['Voltra_AppGroupIdentifier'] = groupIdentifier
 
       writeFileSync(filePath, plist.build(content))
     }

plugin/src/index.ts

@@ -19,8 +19,13 @@ const withVoltra: VoltraConfigPlugin = (config, props) => {
   // Validate props at entry point
   validateProps(props)
 
+  // After validation, props is guaranteed to be defined and have groupIdentifier
+  if (!props) {
+    throw new Error('Voltra plugin requires configuration. Please provide at least groupIdentifier in your plugin config.')
+  }
+
   // Use deploymentTarget from props if provided, otherwise fall back to default
-  const deploymentTarget = props?.deploymentTarget || IOS.DEPLOYMENT_TARGET
+  const deploymentTarget = props.deploymentTarget || IOS.DEPLOYMENT_TARGET
   const targetName = `${IOSConfig.XcodeUtils.sanitizedName(config.name)}LiveActivity`
   const bundleIdentifier = `${config.ios?.bundleIdentifier}.${targetName}`
 
@@ -34,9 +39,9 @@ const withVoltra: VoltraConfigPlugin = (config, props) => {
       ...config.ios?.infoPlist,
       NSSupportsLiveActivities: true,
       NSSupportsLiveActivitiesFrequentUpdates: false,
-      ...(props?.groupIdentifier ? { Voltra_AppGroupIdentifier: props.groupIdentifier } : {}),
+      Voltra_AppGroupIdentifier: props.groupIdentifier,
       // Store widget IDs in Info.plist for native module to access
-      ...(props?.widgets && props.widgets.length > 0 ? { Voltra_WidgetIds: props.widgets.map((w) => w.id) } : {}),
+      ...(props.widgets && props.widgets.length > 0 ? { Voltra_WidgetIds: props.widgets.map((w) => w.id) } : {}),
     },
   }
 
@@ -45,12 +50,12 @@ const withVoltra: VoltraConfigPlugin = (config, props) => {
     targetName,
     bundleIdentifier,
     deploymentTarget,
-    widgets: props?.widgets,
-    groupIdentifier: props?.groupIdentifier,
+    widgets: props.widgets,
+    groupIdentifier: props.groupIdentifier,
   })
 
   // Optionally enable push notifications
-  if (props?.enablePushNotifications) {
+  if (props.enablePushNotifications) {
     config = withPushNotifications(config)
   }
 

plugin/src/types/plugin.ts

@@ -13,7 +13,7 @@ export interface ConfigPluginProps {
   /**
    * App group identifier for sharing data between app and widget extension
    */
-  groupIdentifier?: string
+  groupIdentifier: string
   /**
    * Configuration for home screen widgets
    * Each widget will be available in the widget gallery
@@ -39,7 +39,7 @@ export interface IOSPluginProps {
   bundleIdentifier: string
   deploymentTarget: string
   widgets?: WidgetConfig[]
-  groupIdentifier?: string
+  groupIdentifier: string
   projectRoot: string
   platformProjectRoot: string
 }

plugin/src/validation/validateProps.ts

@@ -7,18 +7,21 @@ import { validateWidgetConfig } from './validateWidget'
  */
 export function validateProps(props: ConfigPluginProps | undefined): void {
   if (!props) {
-    return // No props is valid
+    throw new Error('Voltra plugin requires configuration. Please provide at least groupIdentifier in your plugin config.')
   }
 
-  // Validate group identifier format if provided
-  if (props.groupIdentifier !== undefined) {
-    if (typeof props.groupIdentifier !== 'string') {
-      throw new Error('groupIdentifier must be a string')
-    }
+  // Validate group identifier is provided
+  if (!props.groupIdentifier) {
+    throw new Error('groupIdentifier is required. Please provide a groupIdentifier in your Voltra plugin config.')
+  }
 
-    if (!props.groupIdentifier.startsWith('group.')) {
-      throw new Error(`groupIdentifier '${props.groupIdentifier}' must start with 'group.'`)
-    }
+  // Validate group identifier format
+  if (typeof props.groupIdentifier !== 'string') {
+    throw new Error('groupIdentifier must be a string')
+  }
+
+  if (!props.groupIdentifier.startsWith('group.')) {
+    throw new Error(`groupIdentifier '${props.groupIdentifier}' must start with 'group.'`)
   }
 
   // Validate widgets if provided