-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String picker search field #701
Comments
@CelticMinstrel Here's how it looks: ![]() One thing that's troublesome is you expect 'Enter' to run the search you've typed in, but it clicks OK instead. But I'm not so sure making the search button the default would be good to do in every string picker. And whether it (the search feature) should be made optional per dialog type. Maybe it could automatically appear for multipage pickers? For the 'give item' debug action picker shown here what I'd like is for the search to be Enter and the "OK" button to say "Give", with g as its key. |
Hmm, yeah, this design is a bit troublesome. From what I recall, the notion of "focus" in dialogxml is very basic, and there is no concept of having no field focused. If that concept existed, my expectation would be to hit search if the field has focus and hit OK if it does not. But, there are other options that come to mind.
Also, the button should have a keyboard shortcut of Ctrl+F. I also think the status text just below the field should be in a slightly smaller font size.
It seems like it would be really hard to generalize it down to something that can be used in any dialog. The specific logic of the search in particular depends on the dialog.
Changing the label on the button is as easy as |
I was thinking that a kludgy concept of 'focus' could be added to this specific dialog, by manually toggling the dialog's default button in response to:
|
I meant multipage string pickers. |
I went with this solution. |
It will fit at the top of the dialog, there's some blank space by the dialog picture. You'll type into it and click a Search button. It'll do a case-insensitive search of the strings starting from the current page. It'll set a highlight color on matching strings. If there are none on the current page or you hit the button twice, it'll proceed to the next page with a match. It can have a little label that might tell you 'No matches' or 'Reached end, looping'
The text was updated successfully, but these errors were encountered: