OK/Cancel buttons: positioning should be standard

[NQNStudios]

We've got a bunch of <action>-confirm.xml dialogs where Yes/OK is on the left and No/Cancel is on the right. This tripped me up recently because we also have several dialogs where Cancel is on the Left and OK is on the right.

Examples, non-exhaustive:

Cancel on the Left:

• edit-shop-item.xml
• edit-item.xml
• get-num.xml

Cancel on the right:

• steal-item.xml
• delete-pc-confirm.xml
• preview-dialogs-confirm.xml

And we have 196 dialogs now, so I don't want to survey all of them right now.

Another issue raised by this for me is that whenever I've needed to add a confirmation dialog, I've done it by picking an existing confirmation dialog (quite arbitrarily) and copy-pasting, then editing. So maybe I've been proliferating new confirmation dialogs that didn't match each other, based on which one I sourced from. Not a great practice.

They're all basically the same--and yet, reordering the buttons or trying to keep their order standard is O(N) in developer time because you have to edit each XML file. I think we should probably have a text resource with confirmation texts, and a cChoiceDialog wrapper function that runs a confirmation dialog, the same base dialogxml for each one, allowing you to choose whether it's OK/Cancel or Yes/No.

I'm imagining for the ones where OK is on the left, which feels less natural to me, this was done because they are dangerous or destructive confirmations, and the idea is to prevent someone on autopilot from doing a thing they regret? Or that whichever is Default goes on the right? idk. I feel like they should all be the same and OK should always be on the right. I mean, look at the GitHub comment editor I'm typing in right now:

[NQNStudios]

@CelticMinstrel before I decide to put in the work, what do you think about this one?

[NQNStudios]

I think a better way to really safeguard against careless destructive actions would be: add an 'I understand' LED to the dialogxml and let severe actions pass an argument to show it and require it be activated.

[CelticMinstrel]

before I decide to put in the work, what do you think about this one?

After looking at a random MacOS dialog, I think putting OK on the right makes more sense.