Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplying database password via file? #65

Open
oerp-odoo opened this issue Nov 11, 2021 · 0 comments
Open

Supplying database password via file? #65

oerp-odoo opened this issue Nov 11, 2021 · 0 comments

Comments

@oerp-odoo
Copy link

I see that with marabunta there are two ways to supply password. Either directly on command line or via environment variable. Direct password does not feel secure. Where environment variable is more secure, but it could still be accidentally leaked via some logs etc. So I would better not pass raw password value with that either.

What do you think about third option, to pass password as a file which is then read by marabunta. This way password would not be supplied directly.

I like the way postgres docker implemented this (https://github.com/docker-library/postgres/blob/dd84d6fccbab39bb67fb8f80b9fb2bfc5cb0c992/13/bullseye/docker-entrypoint.sh#L9). You can either use POSTGRES_PASSWORD env or POSTGRES_PASSWORD_FILE (but not both), if you pass POSTGRES_PASSWORD, it works same way as marabunta, but if you pass POSTGRES_PASSWORD_FILE, it reads value from specified file path.

So maybe it would be good to add third option --db-password-file and MARABUNTA_DB_PASSWORD_FILE env?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant