Support Snapcraft advanced grammar in plugin parameters?

[brlin-tw]

What needs to get done

Not exactly sure as the implementation of advanced grammar seems to be in the Snapcraft project, will that be reusable here?

Why it needs to get done

Hello, I would like to implement the following Snapcraft part definition:

parts:
  main:
    plugin: cmake
    cmake-parameters:
      - to armhf:
          - -DGGML_VULKAN=OFF
      - else:
          - -DGGML_VULKAN=ON

However this errors with:

$ snapcraft pack --debug
Bad snapcraft.yaml content:
- input should be a valid string (in field 'parts.main.cmake-parameters[10]')
- input should be a valid string (in field 'parts.main.cmake-parameters[11]')

as (AFAICT) plugin parameters do not have advanced grammar support.

This feature is especially helpful in Snapcraft as architecture-specific build configurations are quite common.

[lengau]

Hi, thanks for the report.

I'm going to move this to craft-application since that's where we apply grammar, though we may consider doing this on a per-app basis as well.

CC @cmatsuoka @bepri

[lengau]

Question for @cmatsuoka: do you know why these values aren't included (is it because the keys are so dynamic)?

[cmatsuoka]

Question for @cmatsuoka: do you know why these values aren't included (is it because the keys are so dynamic)?

I'm not aware of any conceptual reason for not allowing this, but plugin parameter handling will require some extra work to implement.