[PoC] Ressaign correction#1714
Merged
Viktor-Kalashnykov-da merged 9 commits intoMay 8, 2026
Merged
Conversation
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
commented
May 6, 2026
| options?: Partial<{ | ||
| expectHeavyLoad?: boolean | ||
| grantUserRights?: boolean | ||
| skipExistenceCheck?: boolean |
Contributor
Author
There was a problem hiding this comment.
this is not a good solution - only quickly generated,
actually change code below to check if party exists on given synchronizer (if provided)
- Remove reassignBobContractsToGlobal (step 6c): Bob mints Token on app-synchronizer and Canton automatically reassigns to global when the allocation is prescribed there. - Remove party.ts utility: use SDK's party.external.create().sign().execute() directly for registering parties on additional synchronizers. - Add skipExistenceCheck option to SDK's SignedPartyCreationService.execute() to allow re-registering an existing party on a new synchronizer. Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
4be7aa0 to
9ca212e
Compare
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
commented
May 6, 2026
| Omit<OperationBodyRequest<Operation>, UnusedParams | RequiredParams> | ||
| > | ||
|
|
||
| export interface ReassignParams { |
Contributor
Author
There was a problem hiding this comment.
Actually we do not use this function in this version of example....but only cause we did quite artificial hack with Bob Transfer - so I keep it -> Maybe it is actually better to keep it
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
commented
May 6, 2026
| * Self-transfers Alice's TestToken on app-synchronizer via TransferFactory_Transfer. | ||
| * Both TokenRules (the factory) and Alice's Token have been reassigned to app-synchronizer | ||
| * in step 11c, so the submission targets app-synchronizer. | ||
| * Bob self-transfers a portion of his remaining TestToken holding from global |
Contributor
Author
There was a problem hiding this comment.
This is "hack" that allows to get away without use of sdk.ledger.internal reassign.
causes auto-reassign ot TokenRules to app-synchronizer
but really feels like hack
* Replaced location of DARs of TradeApp V1 and TestToken V1 Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com> * Improvement: replaced Bob's self transfer of Tokens to reassignment of Token and Token Rules contracts. Updated documentation for example Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com> * Fix: added splice-test-token-v1 DAR to example Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com> * Improvement: added changes in README file of example and exluded example 15 from single sync tests in CI Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com> --------- Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
f512d2f
into
wiktor/multisync-example
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THis is PoC mostly genrated using agent - just to show working example
This is only demonstration: do not merge
(one manual reassignment needed)