Wallet SDK V1 asserting registry data

[PHOL-DA]

we need to add assertion in certain areas surrounding create commands, case specifically is:
https://github.com/canton-network/wallet-gateway/blob/b3ca0b5bfe336dfd8bca466c621b33ecae58d49c/sdk/wallet-sdk/src/wallet/namespace/amulet/preapproval.ts#L59

if amulet.admin is undefined, then a correct command will be created, but without the expectedDSO field, which can even be submitted, but wont work as a valid CC preapproval.

[rukmini-basu-da]

How can you repro this? We get amulet from

const amulet = await fetchAmulet(this.ctx)

which returns an AssetBody and the type is:

type AssetBody = {
    id: string
    displayName: string
    symbol: string
    registryUrl: string
    admin: PartyId
}

So it's unclear how the admin can be undefined

[PHOL-DA]

here is how to reproduce it:
https://github.com/PHOL-DA/wallet-sdk-testing/tree/phol/bug/1797

log output:

[09:10:39.318] WARN (LedgerProvider/2380559): Error in getWithRetry for path /v2/authenticated-user with retry options {"retries":5,"delayMs":3000,"cantonErrorKeys":["SEQUENCER_REQUEST_FAILED","SEQUENCER_BACKPRESSURE","SUBMISSION_ALREADY_IN_FLIGHT","LOCAL_VERDICT_TIMEOUT","NOT_SEQUENCED_TIMEOUT","NO_VIEW_WITH_VALID_RECIPIENTS"]}
    component: "LedgerClient"
[09:10:39.293] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.325] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.335] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.342] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[newAddress] partyId is test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae
[newAddress] transferPreApprovalProposal is {
  "CreateCommand": {
    "templateId": "#splice-wallet:Splice.Wallet.TransferPreapproval:TransferPreapprovalProposal",
    "createArguments": {
      "provider": "app_user_localnet-localparty-1::1220e099801f195dead4cd8361a5d8831f08bb447d8359b6efccabe9f32d590a1255",
      "receiver": "test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae"
    }
  }
}
[09:10:42.463] INFO (2380559): (ExternalPartyClient)/Party allocated successfully.
result is {
  "updateId": "1220753d04fc00d4dcab92842f0ff74f757ab5a6867638068a3b31a9f684ec3dbfbf",
  "completionOffset": 72
}

key output is:

[newAddress] transferPreApprovalProposal is {
  "CreateCommand": {
    "templateId": "#splice-wallet:Splice.Wallet.TransferPreapproval:TransferPreapprovalProposal",
    "createArguments": {
      "provider": "app_user_localnet-localparty-1::1220e099801f195dead4cd8361a5d8831f08bb447d8359b6efccabe9f32d590a1255",
      "receiver": "test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae"
    }
  }
}

here there should be a third createArgument expectedDSO

[rukmini-basu-da]

Weirdly enough, this is what I get when I run from the wallets repo :

rukminibasu@rukminibasufj726c splice-wallet-kernel % yarn workspace docs-wallet-integration-guide-examples run-15
[08:14:27.720] INFO (20746): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTkyODY3LCJleHAiOjE3NzkxOTY0NjcsImlzcyI6InVuc2FmZS1hdXRoIn0.2l7zi9u41qOI4EVy025gDl526E-1qFi5D7if2_1HORk
[08:14:27.891] INFO (20746): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTkyODY3LCJleHAiOjE3NzkxOTY0NjcsImlzcyI6InVuc2FmZS1hdXRoIn0.2l7zi9u41qOI4EVy025gDl526E-1qFi5D7if2_1HORk
[08:14:27.940] INFO (20746): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTkyODY3LCJleHAiOjE3NzkxOTY0NjcsImlzcyI6InVuc2FmZS1hdXRoIn0.2l7zi9u41qOI4EVy025gDl526E-1qFi5D7if2_1HORk
[08:14:27.948] INFO (20746): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTkyODY3LCJleHAiOjE3NzkxOTY0NjcsImlzcyI6InVuc2FmZS1hdXRoIn0.2l7zi9u41qOI4EVy025gDl526E-1qFi5D7if2_1HORk
[newAddress] partyId is test::1220f9af0ce13f88b1518dee228b31a65c9f0378f1e62e2405236f7c58c6e66731cd
[08:14:31.227] INFO (20746): (ExternalPartyClient)/Party allocated successfully.
[newAddress] transferPreApprovalProposal is {
  "CreateCommand": {
    "templateId": "#splice-wallet:Splice.Wallet.TransferPreapproval:TransferPreapprovalProposal",
    "createArguments": {
      "provider": "app_user_localnet-localparty-1::12207d456c8eba210712904c4ae1cf6e85378429c69ae3a535e82d3fcd3dc5e669bb",
      "receiver": "test::1220f9af0ce13f88b1518dee228b31a65c9f0378f1e62e2405236f7c58c6e66731cd",
      "expectedDso": "DSO::12203dbf52ed787fff1e243b4bd96815e33a7739de93ec5b92e68862884fb6719ea5"
    }
  }
}
[08:14:31.252] INFO (20746): (AmuletNamespace)/amulet: {"id":"Amulet","displayName":"Amulet","symbol":"AMT","registryUrl":"http://127.0.0.1:2000/api/validator/v0/scan-proxy","admin":"DSO::12203dbf52ed787fff1e243b4bd96815e33a7739de93ec5b92e68862884fb6719ea5"}
result is {
  "updateId": "1220f59c3632393e0960fbb385bdb0bb41ba4b91a6a5896d2a5b7ccb814b51475d77",
  "completionOffset": 41
}

When I pull the other branch from the sdk testing repo after running yarn install and yarn build (this has a bunch of errors but in your README indicates this is normal) and then yarn run-1 I get this:

rukminibasu@rukminibasufj726c wallet-sdk-testing % yarn run-1
/Users/rukminibasu/Desktop/IdeaProjects/wallet-sdk-testing/.pnp.cjs:8713
          Error.captureStackTrace(err);
                ^

Error: require() of ES Module /Users/rukminibasu/.yarn/berry/cache/strip-json-comments-npm-5.0.3-5042d1b870-10c0.zip/node_modules/strip-json-comments/index.js from /Users/rukminibasu/.yarn/berry/cache/pino-pretty-npm-13.1.1-9105c2b985-10c0.zip/node_modules/pino-pretty/bin.js not supported.
Instead change the require of index.js in /Users/rukminibasu/.yarn/berry/cache/pino-pretty-npm-13.1.1-9105c2b985-10c0.zip/node_modules/pino-pretty/bin.js to a dynamic import() which is available in all CommonJS modules.
    at require$$0.Module._extensions..js (/Users/rukminibasu/Desktop/IdeaProjects/wallet-sdk-testing/.pnp.cjs:8713:17)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at require$$0.Module._load (/Users/rukminibasu/Desktop/IdeaProjects/wallet-sdk-testing/.pnp.cjs:8564:31)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/Users/rukminibasu/.yarn/berry/cache/pino-pretty-npm-13.1.1-9105c2b985-10c0.zip/node_modules/pino-pretty/bin.js:14:40)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at require$$0.Module._extensions..js (/Users/rukminibasu/Desktop/IdeaProjects/wallet-sdk-testing/.pnp.cjs:8717:35) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v18.13.0
node:fs:1596
  handleErrorFromBinding(ctx);
  ^

Error: ENOTDIR: not a directory, stat '/Users/rukminibasu/.yarn/berry/cache/tsx-npm-4.20.5-9ac8e9c8bf-10c0.zip/node_modules/tsx/dist/loader.mjs'
    at statSync (node:fs:1596:3)
    at tryStatSync (node:internal/modules/esm/resolve:176:13)
    at finalizeResolution (node:internal/modules/esm/resolve:316:17)
    at moduleResolve (node:internal/modules/esm/resolve:945:10)
    at defaultResolve (node:internal/modules/esm/resolve:1153:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:842:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:525:22)
    at initializeLoader (node:internal/process/esm_loader:75:58) {
  errno: -20,
  syscall: 'stat',
  code: 'ENOTDIR',
  path: '/Users/rukminibasu/.yarn/berry/cache/tsx-npm-4.20.5-9ac8e9c8bf-10c0.zip/node_modules/tsx/dist/loader.mjs'
}

I'm running against localnet (with yarn start:localnet), checked out the @canton-network/wallet-sdk@1.2.1 tag to add the script, and ran this with yarn workspace docs-wallet-integration-guide-examples run-15 script - anything i'm missing here?