From 67430759bc4632ad1cfee475854dc1001cdf7c8c Mon Sep 17 00:00:00 2001 From: Alex Matson Date: Wed, 20 May 2026 13:58:04 -0400 Subject: [PATCH] fix: rename JsCommands to Commands Signed-off-by: Alex Matson --- api-specs/openrpc-dapp-api.json | 6 +++--- core/wallet-dapp-remote-rpc-client/src/index.ts | 4 ++-- core/wallet-dapp-rpc-client/src/index.ts | 4 ++-- core/wallet-dapp-rpc-client/src/openrpc.json | 6 +++--- sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts | 4 ++-- wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts | 4 ++-- wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts | 4 ++-- wallet-gateway/remote/src/utils.ts | 4 ++-- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/api-specs/openrpc-dapp-api.json b/api-specs/openrpc-dapp-api.json index 280a87901..f2f808c18 100644 --- a/api-specs/openrpc-dapp-api.json +++ b/api-specs/openrpc-dapp-api.json @@ -261,7 +261,7 @@ "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/CommandId" }, "commands": { - "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/JsCommands" + "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/Commands" }, "actAs": { "title": "actAs", @@ -409,8 +409,8 @@ } ] }, - "JsCommands": { - "title": "JsCommands", + "Commands": { + "title": "Commands", "type": "array", "minItems": 1, "description": "Non-empty array of Daml command atoms to submit atomically as a single transaction.", diff --git a/core/wallet-dapp-remote-rpc-client/src/index.ts b/core/wallet-dapp-remote-rpc-client/src/index.ts index 88db8de2c..b0af3f752 100644 --- a/core/wallet-dapp-remote-rpc-client/src/index.ts +++ b/core/wallet-dapp-remote-rpc-client/src/index.ts @@ -71,7 +71,7 @@ export type Command = * Non-empty array of Daml command atoms to submit atomically as a single transaction. * */ -export type JsCommands = Command[] +export type Commands = Command[] /** * * The party that signed the transaction. @@ -509,7 +509,7 @@ export interface MessageSignatureFailedEvent { */ export interface PrepareExecuteParams { commandId?: CommandId - commands: JsCommands + commands: Commands actAs?: ActAs readAs?: ReadAs disclosedContracts?: DisclosedContracts diff --git a/core/wallet-dapp-rpc-client/src/index.ts b/core/wallet-dapp-rpc-client/src/index.ts index 70644a805..bfd86223d 100644 --- a/core/wallet-dapp-rpc-client/src/index.ts +++ b/core/wallet-dapp-rpc-client/src/index.ts @@ -71,7 +71,7 @@ export type Command = * Non-empty array of Daml command atoms to submit atomically as a single transaction. * */ -export type JsCommands = Command[] +export type Commands = Command[] /** * * The party that signed the transaction. @@ -501,7 +501,7 @@ export interface MessageSignatureFailedEvent { */ export interface PrepareExecuteParams { commandId?: CommandId - commands: JsCommands + commands: Commands actAs?: ActAs readAs?: ReadAs disclosedContracts?: DisclosedContracts diff --git a/core/wallet-dapp-rpc-client/src/openrpc.json b/core/wallet-dapp-rpc-client/src/openrpc.json index 280a87901..f2f808c18 100644 --- a/core/wallet-dapp-rpc-client/src/openrpc.json +++ b/core/wallet-dapp-rpc-client/src/openrpc.json @@ -261,7 +261,7 @@ "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/CommandId" }, "commands": { - "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/JsCommands" + "$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/Commands" }, "actAs": { "title": "actAs", @@ -409,8 +409,8 @@ } ] }, - "JsCommands": { - "title": "JsCommands", + "Commands": { + "title": "Commands", "type": "array", "minItems": 1, "description": "Non-empty array of Daml command atoms to submit atomically as a single transaction.", diff --git a/sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts b/sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts index 1a0537075..5df96d791 100644 --- a/sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts +++ b/sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts @@ -70,7 +70,7 @@ export type Command = * Non-empty array of Daml command atoms to submit atomically as a single transaction. * */ -export type JsCommands = Command[] +export type Commands = Command[] /** * * The party that signed the transaction. @@ -500,7 +500,7 @@ export interface MessageSignatureFailedEvent { */ export interface PrepareExecuteParams { commandId?: CommandId - commands: JsCommands + commands: Commands actAs?: ActAs readAs?: ReadAs disclosedContracts?: DisclosedContracts diff --git a/wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts b/wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts index 1a0537075..5df96d791 100644 --- a/wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts +++ b/wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts @@ -70,7 +70,7 @@ export type Command = * Non-empty array of Daml command atoms to submit atomically as a single transaction. * */ -export type JsCommands = Command[] +export type Commands = Command[] /** * * The party that signed the transaction. @@ -500,7 +500,7 @@ export interface MessageSignatureFailedEvent { */ export interface PrepareExecuteParams { commandId?: CommandId - commands: JsCommands + commands: Commands actAs?: ActAs readAs?: ReadAs disclosedContracts?: DisclosedContracts diff --git a/wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts b/wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts index f9773d7b8..b8dd2486e 100644 --- a/wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts +++ b/wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts @@ -70,7 +70,7 @@ export type Command = * Non-empty array of Daml command atoms to submit atomically as a single transaction. * */ -export type JsCommands = Command[] +export type Commands = Command[] /** * * The party that signed the transaction. @@ -508,7 +508,7 @@ export interface MessageSignatureFailedEvent { */ export interface PrepareExecuteParams { commandId?: CommandId - commands: JsCommands + commands: Commands actAs?: ActAs readAs?: ReadAs disclosedContracts?: DisclosedContracts diff --git a/wallet-gateway/remote/src/utils.ts b/wallet-gateway/remote/src/utils.ts index f26f72c54..4e50b0653 100644 --- a/wallet-gateway/remote/src/utils.ts +++ b/wallet-gateway/remote/src/utils.ts @@ -5,7 +5,7 @@ import { v4 } from 'uuid' import { LedgerClient, Types } from '@canton-network/core-ledger-client' import type { DisclosedContracts, - JsCommands, + Commands, PackageIdSelectionPreference, } from './dapp-api/rpc-gen/typings.js' @@ -34,7 +34,7 @@ export async function networkStatus( export interface PrepareParams { commandId?: string - commands?: JsCommands + commands?: Commands actAs?: string[] readAs?: string[] disclosedContracts?: DisclosedContracts