Java: flows #1793
Draft
Java: flows #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Spelling Mistakes
- java/flows.md:80:46 Unknown word "dependenies"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
|
|
||
| Let's take a look at the [CAP SFLIGHT App](https://github.com/SAP-samples/cap-sflight) sample and how we can update it using the flow feature. | ||
|
|
||
| The `cds-feature-flow` has been added to the dependenies. |
There was a problem hiding this comment.
Suggested change
| The `cds-feature-flow` has been added to the dependenies. | |
| The `cds-feature-flow` has been added to the dependences. |
Or maybe one of these: dependencies, dependence, dependents, dependent's?
| ```xml | ||
| <dependency> | ||
| <groupId>com.sap.cds</groupId> | ||
| <artifactId>cds-feature-flows</artifactId> |
| ```xml | ||
| <dependency> | ||
| <groupId>com.sap.cds</groupId> | ||
| <artifactId>cds-feature-flows</artifactId> |
| key TravelUUID : UUID; | ||
| TravelID : Integer default 0 @readonly; | ||
| @flow.status | ||
| TravelStatus : Association to TravelStatus default 'O' @readonly; |
There was a problem hiding this comment.
TravelStatus is not shown in the example and seems to be an intermediate CodeList
| } | ||
| ``` | ||
|
|
||
| We can simply remove the [AcceptRejectHandler](https://github.com/SAP-samples/cap-sflight/blob/main/srv/src/main/java/com/sap/cap/sflight/processor/AcceptRejectHandler.java). All of the logic is taken care of by the flow feature. The flow feature will validate that entry state is `Open`. The flow feature will transit the status to `Accepted` and `Canceled` respectively. |
There was a problem hiding this comment.
"You can simply remove ..."
I fear customers will not investigate existing SFlight code ni depth - you could still name the benefit, that a custom reject handler is not needed due to flow capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, draft for early feedback