Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify banditpam implementation #44

Open
markymarkdavis opened this issue Mar 10, 2021 · 0 comments
Open

Simplify banditpam implementation #44

markymarkdavis opened this issue Mar 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@markymarkdavis
Copy link
Contributor

This is a two part issue that Alex Lazea and I can help implement:

  1. Removing any duplicated/unused code from the banditPAM codebase.
    • We're specifically targeting either pieces of code that aren't being used or other code that is creating class attributes or
      other non optimal pieces of code
  2. Simplifying the algorithm itself into a couple simpler functions with a rewrite of some of those functions.
    • This is to make the code more optimized by replacing the for loop as an apply function.
    • We will also be looking to combine the build and swap methods of banditPAM into one or two methods that will be simpler to read
@rreilly10 rreilly10 added the enhancement New feature or request label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants