Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operand type enums of all arch modules to the one in capstone.h #2633

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Update operand type enums of all arch modules to the one in capstone.h #2633

wants to merge 2 commits into from

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Feb 25, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes #2632. The arch module operand types (e.g. RISCV_OP_REG etc.) were not set for all archs to the main one (CS_OP_REG etc.).

This meant they were not the same value over all architectures.

Test plan

Added for RISCV and x86 (from the issue)

Closing issues

closes #2632

@github-actions github-actions bot added X86 Arch Mips Arch BPF Arch M680X Arch M68K Arch MOS65XX Arch RISCV Arch SH Arch Sparc Arch WASM Arch XCore Arch python bindings java bindings ocaml bindings HPPA Arch Xtensa Arch labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BPF Arch HPPA Arch java bindings M68K Arch M680X Arch Mips Arch MOS65XX Arch ocaml bindings python bindings RISCV Arch SH Arch Sparc Arch WASM Arch X86 Arch XCore Arch Xtensa Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python bindings - incorrect value of operand.type
1 participant
@Rot127