Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platforms] Implement Icon for SideNavMenuItem #447

Closed
3 tasks done
alisonjoseph opened this issue Feb 17, 2025 · 0 comments · Fixed by #452
Closed
3 tasks done

[Platforms] Implement Icon for SideNavMenuItem #447

alisonjoseph opened this issue Feb 17, 2025 · 0 comments · Fixed by #452
Assignees
@alisonjoseph
Labels
area: platforms Used to filter issues in the Carbon for Platforms effort. role: dev 🤖

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Feb 17, 2025 •
edited
Loading

Design issue carbon-design-system/carbon#18292

SideNavMenuItem needs to be able to display an icon with correct spacing.

Tasks

  • Add renderIcon prop to SideNavMenuItem
  • Update storybook: default & SideNav with third level
  • Update stackblitz example

Questions

Design spec - With icon at level 2

Image
@alisonjoseph alisonjoseph added role: dev 🤖 area: platforms Used to filter issues in the Carbon for Platforms effort. labels Feb 17, 2025
@alisonjoseph alisonjoseph self-assigned this Feb 17, 2025
@alisonjoseph alisonjoseph moved this from Backlog to In Progress in Carbon for Platforms Feb 17, 2025
@alisonjoseph alisonjoseph moved this from In Progress to In Review in Carbon for Platforms Feb 20, 2025
@alisonjoseph alisonjoseph mentioned this issue Feb 20, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in Carbon for Platforms Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonjoseph alisonjoseph

Labels
area: platforms Used to filter issues in the Carbon for Platforms effort. role: dev 🤖
Projects
Carbon for Platforms
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(SideNav): add renderIcon to SideNavMenuItem alisonjoseph/carbon-labs
1 participant
@alisonjoseph