-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some packages from cardano-wallet to CHaP #949
Conversation
Hi @abailly, thank you for this PR! I am wondering about it's status, is there something pending or are we awaiting approval? |
AFAIK we are waiting approval, but this is beyond my karma level :) |
Might be worth creating a CF team & giving update privileges to it for packages added by this PR. |
Sure, that would be great :) |
approved for CI run. WIll review after it finishes. |
Looks like you need a rebase |
b3ea52a
to
4bbd75d
Compare
It seems there's something wrong with the build environment provided by nix but I have no idea why: https://github.com/IntersectMBO/cardano-haskell-packages/actions/runs/12416333194/job/34664923801#step:7:2649 |
@disassembler @andreabedini Could you please advise on how to move forward with this build issue? |
972ef8d
to
8ff4809
Compare
Any news on this @disassembler @hamishmack ? Is there anything I or the team can do to help? |
This is your friendly weekly reminder this PR is still open for reasons I don't understand. |
See #996. |
From https://github.com/cardano-foundation/cardano-wallet-agda at f3479b501a2efe50bcf1ee0d09bc2d1325a982e7
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
From https://github.com/cardano-foundation/cardano-wallet at 6965d18868c4b78fedf402c37b0e1d4f1c27a931
I am closing this PR as it surfaced issues within dependency management on our side. Thanks all for your feedback, I will try again with smaller chunks. |
This will fix cardano-foundation/cardano-wallet#4411