Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network page from deposit wallet UI #4963

Closed
paolino opened this issue Jan 31, 2025 · 2 comments · Fixed by #4986
Closed

Remove network page from deposit wallet UI #4963

paolino opened this issue Jan 31, 2025 · 2 comments · Fixed by #4986
Assignees
@paolino
Labels
Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Milestone
2025Q1

Comments

@paolino
Copy link
Collaborator

paolino commented Jan 31, 2025

Why

Network page brings in a big dependency on the wallet api package.

What

Remove the network page from the deposit wallet UI
@paolino paolino added the Improvement Mark a PR as an improvement, for auto-generated CHANGELOG label Jan 31, 2025
@abailly
Copy link
Collaborator

abailly commented Jan 31, 2025

Would it not make more sense to move this to the Cardano-deposit-wallet and wait for #4959 ?

@paolino
Copy link
Collaborator Author

paolino commented Feb 18, 2025 •
edited
Loading

Would it not make more sense to move this to the Cardano-deposit-wallet and wait for #4959 ?

Nope, it will make separation easier

@paolino paolino self-assigned this Feb 18, 2025
@paolino paolino added this to the 2025Q1 milestone Feb 18, 2025
@paolino paolino mentioned this issue Feb 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2025
@abailly
Remove network page from deposit web UI (#4986)
45371a4 
### Changes

- remove network page from deposit web UI

### Issues

fix #4963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paolino paolino

Labels
Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
2025Q1
Development

Successfully merging a pull request may close this issue.

Remove network page from deposit web UI cardano-foundation/cardano-wallet
2 participants
@abailly @paolino