-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting restoration point for a wallet created from an xpub #4967
Comments
Thanks a lot @Melraidin for the proposal, we'll definitely have a look. |
Usually yes, because the way it works is the cardano-wallet will start synchronising with the cardano-node from the given point and the node's API requires giving a slot number and a block hash. This is so because in general, it is possible for different nodes to have different blocks at the same slot: Cardano is only eventually consistent and node converges after some time, so if you make a query which is not beyond the Security parameter, slot and hash disambiguate what you are looking for. |
@paolino You worked on the feature referred to in the description, any insights? |
We're making use of cardano-wallet to track offline wallets. As it stands right now this poses some difficulty as we generate the wallet offline then create it at cardano-wallet from the xpub. This creates some delay while we wait for cardano-wallet to sync the wallet before any deposits may be discovered. I'm happy to talk more in depth about our project, please let me know how to best contact you. |
If you could book a meeting on my calendar, that would be awesome: https://calendly.com/arnaud-bailly-ext-cardanofoundation/30min |
@Melraidin Thanks for taking the time to talk with the team, that's been helpful to understand better this particular issue and the general problem you're facing. I have created a discussion to explore some potential solution to your problem, feel free to comment if you will: #4981 |
@Melraidin The issue should be fixed in recent commit, would be able to validate it fits your purpose? |
Why?
In #4382 support was added to allow restoring a wallet from a given block. This would be especially useful for my purpose as we know when creating the wallet at cardano-wallet that no transactions would have occurred prior to this creation.
Is it possible to add this support? Along with this, is it necessary to specify both a block hash and an absolute slot number when setting this restoration point?
What?
Add support to match the functionality of the
restoration_point
when creating a Shelly wallet from an xpub.How?
No response
The text was updated successfully, but these errors were encountered: