Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ledger to validate externally signed transactions in CdW #4973

Open
paolino opened this issue Feb 5, 2025 · 0 comments
Open

Use ledger to validate externally signed transactions in CdW #4973

paolino opened this issue Feb 5, 2025 · 0 comments
Labels
Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG

Comments

@paolino
Copy link
Collaborator

paolino commented Feb 5, 2025

Why

ATM externally signed transactions are passed through, which is a feature, but we do not have feedback about their validity if not from the node.

What

Add a ledger based pre-check on externally signed txs during the state change,

step _ (Unsigned utx) (ExternallySign stx) = do
pure $ Just $ Signed utx stx

Notes

It will involve a more sophisticated behavior so that we can track the state transition failure reason.

@paolino paolino added Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

No branches or pull requests

1 participant