Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Refactor mod binstall::install #288

Closed
NobodyXu opened this issue Aug 8, 2022 · 3 comments
Closed

Chore: Refactor mod binstall::install #288

NobodyXu opened this issue Aug 8, 2022 · 3 comments
Labels
Report: enhancement Request for improvements to existing features or code

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Aug 8, 2022

From #282 (comment) :

The binstall::install module needs a refactor though to expose the underlying functions instead of taking Resolution.
@NobodyXu NobodyXu added the Report: enhancement Request for improvements to existing features or code label Aug 8, 2022
@NobodyXu NobodyXu self-assigned this Aug 8, 2022
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 8, 2022

@passcod Since you are doing #260, would you like to also do this to avoid more merge conflicts?

@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 8, 2022

And perhaps also #279 since these two issues are closely related to each other.

@NobodyXu NobodyXu assigned passcod and unassigned NobodyXu Aug 9, 2022
@NobodyXu
Copy link
Member Author

Closed as we don't need it right now.

@NobodyXu NobodyXu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Report: enhancement Request for improvements to existing features or code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@passcod @NobodyXu