Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index_streaming_dataset take in an IterableDataset #24

Open
cakiki opened this issue Feb 20, 2023 · 1 comment
Open

Make index_streaming_dataset take in an IterableDataset #24

cakiki opened this issue Feb 20, 2023 · 1 comment

Comments

@cakiki
Copy link
Collaborator

cakiki commented Feb 20, 2023

Current signature is: dataset_name_or_path: str. I think it would be better to separate streaming a dataset from streaming the indexing and have the function take a datasets.IterableDataset object as input because that's what's returned from the data subpackage. e.g. when loading a streaming dataset from ir_datasets with: hf_dset_streaming = load_ir_dataset_streaming(IR_DSET).

WDYT @ToluClassics @theyorubayesian

@theyorubayesian
Copy link
Member

Doesn't sound too difficult to implement & it's a separation of concerns so it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants