You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current signature is: dataset_name_or_path: str. I think it would be better to separate streaming a dataset from streaming the indexing and have the function take a datasets.IterableDataset object as input because that's what's returned from the data subpackage. e.g. when loading a streaming dataset from ir_datasets with: hf_dset_streaming = load_ir_dataset_streaming(IR_DSET).
Current signature is:
dataset_name_or_path: str
. I think it would be better to separate streaming a dataset from streaming the indexing and have the function take adatasets.IterableDataset
object as input because that's what's returned from thedata
subpackage. e.g. when loading a streaming dataset fromir_datasets
with:hf_dset_streaming = load_ir_dataset_streaming(IR_DSET)
.WDYT @ToluClassics @theyorubayesian
The text was updated successfully, but these errors were encountered: