Fix publisher group garbage cleaning logic #2645
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group spans are exclusive of the end round. Publisher should only retain groups with end rounds greater than the current round
michael-yxchen
requested review from
ariqchowdhury and
omegablitz
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the publisher's group garbage collection logic by correctly implementing exclusive end round semantics. The group retention logic now properly retains groups where the end round is strictly greater than the current round, rather than greater-than-or-equal.
- Changed the group retention condition from
>=to>to correctly implement exclusive end round semantics
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eerkaijun
approved these changes
Dec 9, 2025
omegablitz
approved these changes
Dec 9, 2025
dshulyak
reviewed
Dec 9, 2025
Contributor
dshulyak
left a comment
dshulyak
left a comment
There was a problem hiding this comment.
is it possible to have unit test for this?
Contributor
Author
|
yeah I'll add a unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group spans are exclusive of the end round. Publisher should only retain groups with end rounds greater than the current round