default cleanup

Author: jhunsaker

category/execution/ethereum/trace/call_frame.cpp

@@ -46,9 +46,8 @@ constexpr std::string_view call_kind_to_string(CallType const &type)
         return "CREATE2";
     case CallType::SELFDESTRUCT:
         return "SELFDESTRUCT";
-    default:
-        MONAD_ASSERT(false);
     }
+    MONAD_ABORT(); // unreachable
 }
 
 MONAD_ANONYMOUS_NAMESPACE_END

category/execution/ethereum/trace/call_tracer.cpp

@@ -127,9 +127,10 @@ void CallTracer::on_enter(evmc_message const &msg)
                     return CallType::CREATE;
                 case EVMC_CREATE2:
                     return CallType::CREATE2;
-                default:
-                    MONAD_ASSERT(false);
+                case EVMC_EOFCREATE:
+                    MONAD_ABORT(); // unsupported
                 }
+                MONAD_ABORT(); // unreachable
             }(),
         .flags = msg.flags,
         .from = from,

category/execution/monad/staking/fuzzer/staking_contract_machine.cpp

@@ -681,8 +681,8 @@ namespace monad::staking::test
         case Transition::precompile_get_delegator:
             precompile_get_delegator();
             break;
-        default:
-            MONAD_ABORT();
+        case Transition::TRANSITION_COUNT:
+            MONAD_ABORT(); // invalid enum value
         }
         // Skip `WITHDRAWAL_DELAY` epochs once in a while to allow for
         // withdrawal requests become ready in a more natural way than
@@ -721,9 +721,10 @@ namespace monad::staking::test
             return "Transition::precompile_external_reward";
         case Transition::precompile_get_delegator:
             return "Transition::precompile_get_delegator";
-        default:
-            MONAD_ABORT();
+        case Transition::TRANSITION_COUNT:
+            MONAD_ABORT(); // invalid enum value
         }
+        MONAD_ABORT(); // unreachable
     }
 
     template <Traits traits>

category/vm/compiler/ir/x86/emitter.cpp

@@ -269,9 +269,8 @@ namespace monad::vm::compiler::native
             return "StackOffset";
         case Emitter::LocationType::Literal:
             return "Literal";
-        default:
-            MONAD_VM_ASSERT(false);
         }
+        return ""; // unreachable
     }
 
     template <size_t N>