expand clang-tidy checks to category/rpc

Author: mkolosick

category/core/hash.hpp

@@ -38,6 +38,7 @@ struct fnv1a_hash
         static constexpr working_type prime = 1099511628211ULL;
         unsigned char const *const _v =
             reinterpret_cast<unsigned char const *>(&v);
+        // NOLINTNEXTLINE(bugprone-sizeof-expression)
         for (size_t n = 0; n < sizeof(T); n++) {
             hash ^= static_cast<working_type>(_v[n]);
             hash *= prime;

category/core/lru/lru_cache.hpp

@@ -135,7 +135,7 @@ class LruCache
     void try_update_lru(ListNode *node)
     {
         if (node->check_lru_time()) {
-            std::unique_lock l(mutex_);
+            std::unique_lock const l(mutex_);
             STATS_EVENT_UPDATE_LRU();
             lru_.update_lru(node);
         }
@@ -146,7 +146,7 @@ class LruCache
         size_t sz = size();
         bool const evicted = (sz >= max_size_) && evict();
         {
-            std::unique_lock l(mutex_);
+            std::unique_lock const l(mutex_);
             STATS_EVENT_INSERT_NEW();
             lru_.push_front(node);
         }
@@ -170,7 +170,7 @@ class LruCache
     {
         ListNode *target;
         {
-            std::unique_lock l(mutex_);
+            std::unique_lock const l(mutex_);
             STATS_EVENT_EVICT();
             target = lru_.evict();
         }
@@ -196,9 +196,9 @@ class LruCache
         Key key_;
         std::atomic<int64_t> lru_time_{0};
 
-        ListNode() {}
+        ListNode() = default;
 
-        ListNode(Key const &key)
+        explicit ListNode(Key const &key)
             : key_(key)
         {
         }
@@ -297,7 +297,7 @@ class LruCache
         Value value_;
         ListNode *node_;
 
-        HashMapValue() {}
+        HashMapValue() = default;
 
         HashMapValue(Value const &value, ListNode *const node)
             : value_(value)

category/core/mem/batch_mem_pool.hpp

@@ -53,7 +53,7 @@ class BatchMemPool
 #endif
 
 public:
-    BatchMemPool(size_t const initial, size_t const batch = 1024)
+    explicit BatchMemPool(size_t const initial, size_t const batch = 1024)
         : pool_{sizeof(T), initial}
     {
         void *p = pool_.malloc();

category/execution/ethereum/block_hash_buffer.hpp

@@ -85,7 +85,7 @@ class BlockHashChain
     std::deque<Proposal> proposals_;
 
 public:
-    BlockHashChain(BlockHashBufferFinalized &);
+    explicit BlockHashChain(BlockHashBufferFinalized &);
 
     void propose(
         bytes32_t const &, uint64_t block_number, bytes32_t const &block_id,

category/execution/ethereum/db/trie_db.hpp

@@ -54,7 +54,7 @@ class TrieDb final : public ::monad::Db
     ::monad::mpt::Node::SharedPtr curr_root_;
 
 public:
-    TrieDb(mpt::Db &);
+    explicit TrieDb(mpt::Db &);
     ~TrieDb();
 
     void reset_root(::monad::mpt::Node::SharedPtr root, uint64_t block_number);

category/execution/ethereum/db/trie_rodb.hpp

@@ -37,7 +37,7 @@ class TrieRODb final : public ::monad::Db
     ::monad::mpt::CacheNodeCursor prefix_cursor_;
 
 public:
-    TrieRODb(mpt::RODb &db)
+    explicit TrieRODb(mpt::RODb &db)
         : db_(db)
         , block_number_(mpt::INVALID_BLOCK_NUM)
         , prefix_cursor_()

category/execution/ethereum/rlp/decode.hpp

@@ -82,7 +82,7 @@ constexpr Result<byte_string_view> parse_string_metadata(byte_string_view &enc)
     else // [0xb8, 0xbf]
     {
         ++i;
-        uint8_t length_of_length = enc[0] - 0xb7;
+        uint8_t const length_of_length = enc[0] - 0xb7;
 
         if (MONAD_UNLIKELY(i + length_of_length >= enc.size())) {
             return DecodeError::InputTooShort;
@@ -156,6 +156,7 @@ decode_byte_string_fixed(byte_string_view &enc)
     if (MONAD_UNLIKELY(payload.size() != N)) {
         return DecodeError::ArrayLengthUnexpected;
     }
+    // NOLINTNEXTLINE(bugprone-suspicious-stringview-data-usage)
     std::memcpy(bsf.data(), payload.data(), N);
     return bsf;
 }

category/execution/ethereum/rlp/encode2.hpp

@@ -28,8 +28,8 @@ inline byte_string const EMPTY_STRING = {0x80};
 
 inline byte_string_view zeroless_view(byte_string_view const string_view)
 {
-    auto b = string_view.begin();
-    auto const e = string_view.end();
+    auto const *b = string_view.begin();
+    auto const *e = string_view.end();
     while (b < e && *b == 0) {
         ++b;
     }
@@ -73,11 +73,15 @@ byte_string encode_list2(Args const &...args)
     if (size > 55) {
         auto const size_str = to_big_compact(size);
         MONAD_ASSERT(size_str.size() <= 8u);
-        result += (0xf7 + static_cast<unsigned char>(size_str.size()));
+        result +=
+            (static_cast<unsigned char>(0xf7) +
+             static_cast<unsigned char>(size_str.size()));
         result += size_str;
     }
     else {
-        result += (0xc0 + static_cast<unsigned char>(size));
+        result +=
+            (static_cast<unsigned char>(0xc0) +
+             static_cast<unsigned char>(size));
     }
     ([&] { result += args; }(), ...);
     return result;

category/execution/ethereum/state3/account_state.hpp

@@ -77,7 +77,7 @@ class AccountState : public AccountSubstate
 
 public:
     explicit AccountState(std::optional<Account> &&account)
-        : account_{std::move(account)}
+        : account_{account}
     {
     }
 
@@ -162,7 +162,7 @@ class OriginalAccountState final : public AccountState
 
 public:
     explicit OriginalAccountState(std::optional<Account> &&account)
-        : AccountState(std::move(account))
+        : AccountState(account)
     {
     }
 

category/execution/ethereum/state3/version_stack.hpp

@@ -29,7 +29,7 @@ class VersionStack
     std::deque<std::pair<unsigned, T>> stack_{};
 
 public:
-    VersionStack(T value, unsigned version = 0)
+    explicit VersionStack(T value, unsigned version = 0)
     {
         stack_.emplace_back(version, std::move(value));
     }