[eth_call] Fix interaction between prestate tracers and state overrides #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the state override mechanism for eth_call to apply overrides directly to original account states during State object construction, rather than applying them after construction. This ensures that tracers (PreState and StateDiff) capture the correct pre-execution state including overrides.
Key Changes:
- Moved state override application logic from
eth_call.cppinto theStateconstructor - Added a new templated
Stateconstructor that accepts state overrides as a parameter - Modified state overrides to work directly with
OriginalAccountStateinstead of using state mutation methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| category/rpc/eth_call.cpp | Simplified to use new State constructor with state overrides parameter |
| category/execution/ethereum/state3/state.hpp | Added templated constructor that applies state overrides to original account states |
| category/rpc/eth_call_test.cpp | Added test validating PreState and StateDiff tracers with state overrides |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dhil
force-pushed
the
dhil/prestate-overrides
branch
5 times, most recently
from
5b55631 to
76cc85b
Compare
dhil
force-pushed
the
dhil/prestate-overrides
branch
5 times, most recently
from
47b374b to
8bd9c40
Compare
jhunsaker
force-pushed
the
dhil/prestate-overrides
branch
from
8bd9c40 to
becb63d
Compare
dhil
force-pushed
the
dhil/prestate-overrides
branch
from
becb63d to
d3a36d1
Compare
dhil
changed the title
dhil
force-pushed
the
dhil/prestate-overrides
branch
2 times, most recently
from
318b8b7 to
8a2f039
Compare
Baltoli
force-pushed
the
dhil/prestate-overrides
branch
from
8a2f039 to
a6c98a9
Compare
dhil
force-pushed
the
dhil/prestate-overrides
branch
8 times, most recently
from
e6de0be to
461cd7b
Compare
dhil
force-pushed
the
dhil/prestate-overrides
branch
from
461cd7b to
766ec35
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zander-xyz
previously approved these changes
Nov 10, 2025
dhil
force-pushed
the
dhil/prestate-overrides
branch
from
766ec35 to
e90e137
Compare
The problem is that state overrides are applied to `State::current` accounts, whereas the prestate trace is computed from `State::original`. Thus prestate tracers do not respect state overrides. In this patch, we merge the state overrides into the block state before execution, and create a new `State` instance with this updated block state, meaning that the former `State::current` accounts will be `State::original` in the new state instance. This new state instance is then passed to execution.
dhil
force-pushed
the
dhil/prestate-overrides
branch
from
e90e137 to
cc8a0c7
Compare
Baltoli
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.