Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desk review workbook to pull comps using doc numbers #342

Open
jeancochrane opened this issue Feb 11, 2025 · 0 comments · May be fixed by #344
Open

Update desk review workbook to pull comps using doc numbers #342

jeancochrane opened this issue Feb 11, 2025 · 0 comments · May be fixed by #344

Comments

@jeancochrane
Copy link
Contributor

We currently save doc numbers as well as PINs for each comp that a card has, but the desk review workbooks that we output in the export pipeline stage still infer sale dates based on the most recent sale for a comp PIN. This imputation process usually finds the correct value, but it's not guaranteed to be correct. To be safe, we should update the export stage to assign comps using comp doc numbers instead of using the most recent sale for a comp PIN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant