diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/data/batch/SplitReaderAdapter.java b/cdap-api/src/main/java/io/cdap/cdap/api/data/batch/SplitReaderAdapter.java index e8cb963071c6..f32646230be6 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/data/batch/SplitReaderAdapter.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/data/batch/SplitReaderAdapter.java @@ -34,8 +34,8 @@ public SplitReaderAdapter(SplitReader delegate) { protected abstract TO_KEY convertKey(FROM_KEY key); protected abstract TO_VALUE convertValue(FROM_VALUE value); - private TO_KEY nextKey = null; - private TO_VALUE nextValue = null; + private TO_KEY nextKey; + private TO_VALUE nextValue; @Override public void initialize(Split split) throws InterruptedException { diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTable.java b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTable.java index f36ab8935489..56bc8c85e913 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTable.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTable.java @@ -147,7 +147,7 @@ public Iterator read(byte[] counter, long startTime, long endTime, // Returns a limiting Iterator return new Iterator() { - private int count = 0; + private int count; @Override public boolean hasNext() { diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/FileSetProperties.java b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/FileSetProperties.java index e90e1c3a5537..888241a91915 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/FileSetProperties.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/FileSetProperties.java @@ -282,7 +282,7 @@ public static Map propertiesWithPrefix(Map prope */ public static class Builder extends ExploreProperties.AbstractBuilder { - private String format = null; + private String format; /** * Package visible default constructor, to allow sub-classing by other datasets in this package. diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/KeyValueTable.java b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/KeyValueTable.java index 523c4ed37593..c02f295948b6 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/KeyValueTable.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/KeyValueTable.java @@ -248,7 +248,7 @@ public CloseableIterator> scan(byte[] startRow, byte[] final Scanner scanner = table.scan(startRow, stopRow); return new AbstractCloseableIterator>() { - private boolean closed = false; + private boolean closed; @Override protected KeyValue computeNext() { if (closed) { diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/TimeseriesTable.java b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/TimeseriesTable.java index c5ae3cdba33c..e43a203f6c33 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/TimeseriesTable.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/TimeseriesTable.java @@ -159,7 +159,7 @@ public final Iterator read(byte[] key, long startTime, long endTime, } return new Iterator() { - int count = 0; + int count; @Override public boolean hasNext() { diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/partitioned/PartitionAcceptor.java b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/partitioned/PartitionAcceptor.java index ebcd7f28b7ab..8a62694f735a 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/partitioned/PartitionAcceptor.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/dataset/lib/partitioned/PartitionAcceptor.java @@ -50,7 +50,7 @@ enum Return { */ final class Limit implements PartitionAcceptor { - private int count = 0; + private int count; private int limit; public Limit(int limit) { diff --git a/cdap-api/src/main/java/io/cdap/cdap/api/macro/MacroParserOptions.java b/cdap-api/src/main/java/io/cdap/cdap/api/macro/MacroParserOptions.java index b075e37a1ca1..3927cf1822da 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/api/macro/MacroParserOptions.java +++ b/cdap-api/src/main/java/io/cdap/cdap/api/macro/MacroParserOptions.java @@ -82,9 +82,9 @@ public static class Builder { private boolean evaluateLookups = true; private boolean evaluateFunctions = true; private boolean escapingEnabled = true; - private boolean skipInvalid = false; + private boolean skipInvalid; private int maxRecurseDepth = 10; - private Set functionWhitelist = new HashSet<>(); + private final Set functionWhitelist = new HashSet<>(); public Builder disableLookups() { evaluateLookups = false; diff --git a/cdap-api/src/main/java/io/cdap/cdap/internal/io/TypeRepresentation.java b/cdap-api/src/main/java/io/cdap/cdap/internal/io/TypeRepresentation.java index 0d44caccc710..af2326985237 100644 --- a/cdap-api/src/main/java/io/cdap/cdap/internal/io/TypeRepresentation.java +++ b/cdap-api/src/main/java/io/cdap/cdap/internal/io/TypeRepresentation.java @@ -38,7 +38,7 @@ public final class TypeRepresentation implements ParameterizedType { private final String rawType; private final TypeRepresentation enclosingType; private final TypeRepresentation[] parameters; - private transient ClassLoader classLoader = null; + private transient ClassLoader classLoader; /** * Set the class loader to be used by toType(), getRawType(), etc. diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/hive/ExploreUtils.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/hive/ExploreUtils.java index 89d25deb1f0b..1d428c768ed1 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/hive/ExploreUtils.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/hive/ExploreUtils.java @@ -66,7 +66,7 @@ public URL apply(File file) { } }; - private static ClassLoader exploreClassLoader = null; + private static ClassLoader exploreClassLoader; /** * Builds a class loader with the class path provided. diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewDataSubscriberService.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewDataSubscriberService.java index d9027feece57..7f7f1a26b82d 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewDataSubscriberService.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewDataSubscriberService.java @@ -67,8 +67,8 @@ public class PreviewDataSubscriberService extends AbstractMessagingSubscriberSer private final MultiThreadMessagingContext messagingContext; private final TransactionRunner transactionRunner; private final int maxRetriesOnError; - private int errorCount = 0; - private String erroredMessageId = null; + private int errorCount; + private String erroredMessageId; private MetricsCollectionService metricsCollectionService; /** diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewTMSLogSubscriber.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewTMSLogSubscriber.java index a1637f0eac18..394857a7646c 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewTMSLogSubscriber.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/preview/PreviewTMSLogSubscriber.java @@ -55,8 +55,8 @@ public class PreviewTMSLogSubscriber extends AbstractMessagingSubscriberService< private final TransactionRunner transactionRunner; private final RemoteExecutionLogProcessor logProcessor; private final int maxRetriesOnError; - private int errorCount = 0; - private String erroredMessageId = null; + private int errorCount; + private String erroredMessageId; @Inject PreviewTMSLogSubscriber(CConfiguration cConf, diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/MapperWrapper.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/MapperWrapper.java index 22fbe0eb796b..ee1d33cb54f1 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/MapperWrapper.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/MapperWrapper.java @@ -174,8 +174,8 @@ private WrappedMapper.Context createAutoFlushingContext(final Context context, @SuppressWarnings("unchecked") WrappedMapper.Context flushingContext = new WrappedMapper().new Context(context) { - private int processedRecords = 0; - private long nextTimeToReportMetrics = 0L; + private int processedRecords; + private long nextTimeToReportMetrics; @Override public boolean nextKeyValue() throws IOException, InterruptedException { diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/ReducerWrapper.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/ReducerWrapper.java index 938aee810b5f..edf6cfdce225 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/ReducerWrapper.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/ReducerWrapper.java @@ -145,8 +145,8 @@ private WrappedReducer.Context createAutoFlushingContext(final Context context, @SuppressWarnings("unchecked") WrappedReducer.Context flushingContext = new WrappedReducer().new Context(context) { - private int processedRecords = 0; - private long nextTimeToReportMetrics = 0L; + private int processedRecords; + private long nextTimeToReportMetrics; @Override public boolean nextKeyValue() throws IOException, InterruptedException { diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/SimpleJob.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/SimpleJob.java index 9b56cad90a99..d9367bc91821 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/SimpleJob.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/SimpleJob.java @@ -33,7 +33,7 @@ public final class SimpleJob implements Job { private final List notifications; private final State state; private final long scheduleLastUpdatedTime; - private Long deleteTimeMillis = null; + private Long deleteTimeMillis; /** * @param scheduleLastUpdatedTime the last modification time of the schedule, at the time this job is created. diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/TaskWorkerHttpHandlerInternal.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/TaskWorkerHttpHandlerInternal.java index 38d378c17e5a..20497aaee57a 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/TaskWorkerHttpHandlerInternal.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/TaskWorkerHttpHandlerInternal.java @@ -244,7 +244,7 @@ private static class RunnableTaskBodyProducer extends BodyProducer { private final BiConsumer stopper; private final TaskDetails taskDetails; private final boolean terminateOnComplete; - private boolean done = false; + private boolean done; RunnableTaskBodyProducer(RunnableTaskContext context, BiConsumer stopper, TaskDetails taskDetails) { diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/system/SystemWorkerHttpHandlerInternal.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/system/SystemWorkerHttpHandlerInternal.java index d0c20b6615bb..058a054203ab 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/system/SystemWorkerHttpHandlerInternal.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/worker/system/SystemWorkerHttpHandlerInternal.java @@ -140,7 +140,7 @@ private String exceptionToJson(Exception ex) { private static class RunnableTaskBodyProducer extends BodyProducer { private final ByteBuffer response; private final TaskDetails taskDetails; - private boolean done = false; + private boolean done; RunnableTaskBodyProducer(RunnableTaskContext context, TaskDetails taskDetails) { this.response = context.getResult(); diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/workflow/DefaultWorkflowConfigurer.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/workflow/DefaultWorkflowConfigurer.java index 3ee13209a738..fc4bab478d2a 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/workflow/DefaultWorkflowConfigurer.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/workflow/DefaultWorkflowConfigurer.java @@ -68,7 +68,7 @@ public class DefaultWorkflowConfigurer extends AbstractConfigurer private final AppDeploymentRuntimeInfo runtimeInfo; private final List nodes = Lists.newArrayList(); - private int nodeIdentifier = 0; + private int nodeIdentifier; private String name; private String description; private Map properties; diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/metadata/MetadataSubscriberService.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/metadata/MetadataSubscriberService.java index 08c6a3b2006d..5673c7f1abea 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/metadata/MetadataSubscriberService.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/metadata/MetadataSubscriberService.java @@ -115,11 +115,11 @@ public class MetadataSubscriberService extends AbstractMessagingSubscriberServic private final int maxRetriesOnConflict; private final MetricsCollectionService metricsCollectionService; - private String conflictMessageId = null; - private int conflictCount = 0; + private String conflictMessageId; + private int conflictCount; - private boolean didBackfill = false; - private int backfillAttempts = 0; + private boolean didBackfill; + private int backfillAttempts; @Inject MetadataSubscriberService(CConfiguration cConf, MessagingService messagingService, diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/scheduler/ConstraintCheckerService.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/scheduler/ConstraintCheckerService.java index 5d0c8d926c39..a0f27e7bd1ec 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/scheduler/ConstraintCheckerService.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/scheduler/ConstraintCheckerService.java @@ -67,7 +67,7 @@ class ConstraintCheckerService extends AbstractIdleService { private final TransactionRunner transactionRunner; private ScheduleTaskRunner taskRunner; private ListeningExecutorService taskExecutorService; - private volatile boolean stopping = false; + private volatile boolean stopping; @Inject ConstraintCheckerService(Store store, diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/security/ApplicationSecurity.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/security/ApplicationSecurity.java index 21b6d8d399ab..06b382dc88f5 100644 --- a/cdap-app-fabric/src/main/java/io/cdap/cdap/security/ApplicationSecurity.java +++ b/cdap-app-fabric/src/main/java/io/cdap/cdap/security/ApplicationSecurity.java @@ -109,7 +109,7 @@ public static Builder builder() { */ public static class Builder { private final PermissionCollection perms; - private Class klass = null; + private Class klass; /** * Invoked by the {@link #builder()}. diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMisbehavedDataset.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMisbehavedDataset.java index 423cf0088105..92f00682edcb 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMisbehavedDataset.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMisbehavedDataset.java @@ -59,7 +59,7 @@ public void configure() { */ public static class MisbehavedDataset extends AbstractDataset { - private boolean active = false; + private boolean active; public MisbehavedDataset(DatasetSpecification spec, @EmbeddedDataset("t") Table table) { super(spec.getName(), table); diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/program/ProgramStateWriterWithHeartBeatTest.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/program/ProgramStateWriterWithHeartBeatTest.java index 6303701a81bf..f24cde45cc89 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/program/ProgramStateWriterWithHeartBeatTest.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/program/ProgramStateWriterWithHeartBeatTest.java @@ -45,7 +45,7 @@ public class ProgramStateWriterWithHeartBeatTest { private static class MockProgramStatePublisher implements ProgramStatePublisher { - long heartBeatCount = 0; + long heartBeatCount; @Override public void publish(Notification.Type notificationType, Map properties) { diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithMapReduceUsingRuntimeDatasets.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithMapReduceUsingRuntimeDatasets.java index 35d647e33ebf..e04011b0f4bc 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithMapReduceUsingRuntimeDatasets.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithMapReduceUsingRuntimeDatasets.java @@ -116,7 +116,7 @@ public static class FileMapper extends Mapper implements ProgramLifecycle { - private KeyValueTable counters = null; + private KeyValueTable counters; public static final String ONLY_KEY = "x"; @Override @@ -141,7 +141,7 @@ public static class FileReducer extends Reducer implements ProgramLifecycle { - private KeyValueTable counters = null; + private KeyValueTable counters; public void reduce(Text key, Iterable values, Context context) throws IOException, InterruptedException { diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithTxAware.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithTxAware.java index d661189932ec..272ed219f8f7 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithTxAware.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/batch/AppWithTxAware.java @@ -76,8 +76,8 @@ protected void map(Integer key, Integer value, Context context) throws IOExcepti } public static class PedanticTxAware extends AbstractDataset implements BatchReadable { - private Transaction tx = null; - private Transaction remembered = null; + private Transaction tx; + private Transaction remembered; public PedanticTxAware(DatasetSpecification spec, @EmbeddedDataset("t") Table embedded) { super(spec.getName(), embedded); diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/monitor/proxy/TestHandler.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/monitor/proxy/TestHandler.java index 081589b819be..07d826e6cd63 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/monitor/proxy/TestHandler.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/monitor/proxy/TestHandler.java @@ -57,7 +57,7 @@ public void chunk(FullHttpRequest request, HttpResponder responder) { responder.sendContent(HttpResponseStatus.OK, new BodyProducer() { - int count = 0; + int count; @Override public ByteBuf nextChunk() { diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/ProgramLifecycleHttpHandlerInternalTest.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/ProgramLifecycleHttpHandlerInternalTest.java index a92942560200..3144c9709ef8 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/ProgramLifecycleHttpHandlerInternalTest.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/ProgramLifecycleHttpHandlerInternalTest.java @@ -44,7 +44,7 @@ public class ProgramLifecycleHttpHandlerInternalTest extends AppFabricTestBase { private static final String STOPPED = "STOPPED"; private static final String RUNNING = "RUNNING"; - private static ProgramRunRecordFetcher programRunRecordFetcher = null; + private static ProgramRunRecordFetcher programRunRecordFetcher; @BeforeClass public static void init() { diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/provision/MockProvisioner.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/provision/MockProvisioner.java index 96e08dd621de..7b4c9748a32a 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/provision/MockProvisioner.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/provision/MockProvisioner.java @@ -181,10 +181,10 @@ private void validateContext(ProvisionerContext context) { */ public static class PropertyBuilder { private Integer failRetryablyEveryN; - private boolean failCreate = false; - private boolean failGet = false; - private boolean failInit = false; - private boolean failDelete = false; + private boolean failCreate; + private boolean failGet; + private boolean failInit; + private boolean failDelete; private long waitCreateMillis = -1L; private long waitDeleteMillis = -1L; private ClusterStatus firstClusterStatus; diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/tethering/MockTetheringServerHandler.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/tethering/MockTetheringServerHandler.java index abe1d593da2f..a7799e328a1c 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/tethering/MockTetheringServerHandler.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/internal/tethering/MockTetheringServerHandler.java @@ -39,7 +39,7 @@ public class MockTetheringServerHandler extends AbstractHttpHandler { private static final Gson GSON = new Gson(); private HttpResponseStatus responseStatus = HttpResponseStatus.OK; - private boolean tetheringCreated = false; + private boolean tetheringCreated; @GET @Path("/tethering/controlchannels/{peer}") diff --git a/cdap-app-fabric/src/test/java/io/cdap/cdap/metadata/PreferencesFetcherInternalTest.java b/cdap-app-fabric/src/test/java/io/cdap/cdap/metadata/PreferencesFetcherInternalTest.java index 140454a05758..81e590cbf19f 100644 --- a/cdap-app-fabric/src/test/java/io/cdap/cdap/metadata/PreferencesFetcherInternalTest.java +++ b/cdap-app-fabric/src/test/java/io/cdap/cdap/metadata/PreferencesFetcherInternalTest.java @@ -47,7 +47,7 @@ public enum PreferencesFetcherType { REMOTE, }; - private PreferencesFetcherType fetcherType = null; + private PreferencesFetcherType fetcherType; public PreferencesFetcherInternalTest(PreferencesFetcherType type) { this.fetcherType = type; diff --git a/cdap-app-fabric/src/test/java/org/apache/hadoop/util/Shell.java b/cdap-app-fabric/src/test/java/org/apache/hadoop/util/Shell.java index 885b1340bb1f..22f884c21441 100644 --- a/cdap-app-fabric/src/test/java/org/apache/hadoop/util/Shell.java +++ b/cdap-app-fabric/src/test/java/org/apache/hadoop/util/Shell.java @@ -255,7 +255,7 @@ public static String[] getRunScriptCommand(File script) { public static final String READ_LINK_COMMAND = "readlink"; /**Time after which the executing script would be timedout*/ - protected long timeOutInterval = 0L; + protected long timeOutInterval; /** If or not script timed out*/ private AtomicBoolean timedOut; diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/SmartWorkflow.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/SmartWorkflow.java index 27910b56a2ca..530cc45f91f5 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/SmartWorkflow.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/SmartWorkflow.java @@ -150,8 +150,8 @@ public class SmartWorkflow extends AbstractWorkflow { private Metrics workflowMetrics; private ETLBatchConfig config; private BatchPipelineSpec spec; - private int connectorNum = 0; - private int publisherNum = 0; + private int connectorNum; + private int publisherNum; public SmartWorkflow(ETLBatchConfig config, Set supportedPluginTypes, ApplicationConfigurer applicationConfigurer) { diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/AutoJoinerTest.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/AutoJoinerTest.java index 430a1f1e34c1..015a9250a9ee 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/AutoJoinerTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/AutoJoinerTest.java @@ -75,7 +75,7 @@ public class AutoJoinerTest extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); - private static int startCount = 0; + private static int startCount; private static final Schema USER_SCHEMA = Schema.recordOf( "user", Schema.Field.of("region", Schema.of(Schema.Type.STRING)), diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineConnectionTest.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineConnectionTest.java index bb68f19159c8..b119c9850609 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineConnectionTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineConnectionTest.java @@ -133,7 +133,7 @@ public class DataPipelineConnectionTest extends HydratorTestBase { new GsonBuilder().registerTypeAdapter(Schema.class, new SchemaTypeAdapter()) .registerTypeAdapter(SampleResponse.class, new SampleResponseCodec()).setPrettyPrinting().create(); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineTest.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineTest.java index b1f016cd6e88..b87cc21d47a0 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineTest.java @@ -176,7 +176,7 @@ public class DataPipelineTest extends HydratorTestBase { private static final ArtifactId OLD_APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "0.0.9"); private static final ArtifactSummary APP_ARTIFACT_RANGE = new ArtifactSummary("app", "[0.1.0,1.1.0)"); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/ReducibleAggregatorTestBase.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/ReducibleAggregatorTestBase.java index c718973783c3..34f3e7ef12a8 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/ReducibleAggregatorTestBase.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/ReducibleAggregatorTestBase.java @@ -63,7 +63,7 @@ public class ReducibleAggregatorTestBase extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration( diff --git a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/preview/PreviewDataPipelineTest.java b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/preview/PreviewDataPipelineTest.java index 1b6cfe114c0e..176a0bd89377 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/preview/PreviewDataPipelineTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/preview/PreviewDataPipelineTest.java @@ -85,7 +85,7 @@ public class PreviewDataPipelineTest extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT_RANGE = new ArtifactSummary("app", "[0.1.0,1.1.0)"); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, Constants.Security.Store.PROVIDER, "file", diff --git a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsSparkSinkTest.java b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsSparkSinkTest.java index f39c94197e52..49408cfbbac1 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsSparkSinkTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsSparkSinkTest.java @@ -57,7 +57,7 @@ public class DataStreamsSparkSinkTest extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, Constants.AppFabric.SPARK_COMPAT, diff --git a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsTest.java b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsTest.java index 47c62fecdf2e..23a7b1b549bc 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/DataStreamsTest.java @@ -104,7 +104,7 @@ public class DataStreamsTest extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); private static String checkpointDir; - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, Constants.AppFabric.SPARK_COMPAT, diff --git a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/preview/PreviewDataStreamsTest.java b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/preview/PreviewDataStreamsTest.java index f49fccbd455d..49082626e9aa 100644 --- a/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/preview/PreviewDataStreamsTest.java +++ b/cdap-app-templates/cdap-etl/cdap-data-streams-base/src/test/java/io/cdap/cdap/datastreams/preview/PreviewDataStreamsTest.java @@ -70,7 +70,7 @@ public class PreviewDataStreamsTest extends HydratorTestBase { private static final ArtifactId APP_ARTIFACT_ID = NamespaceId.DEFAULT.artifact("app", "1.0.0"); private static final ArtifactSummary APP_ARTIFACT = new ArtifactSummary("app", "1.0.0"); - private static int startCount = 0; + private static int startCount; @ClassRule public static final TestConfiguration CONFIG = new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, Constants.AppFabric.SPARK_COMPAT, diff --git a/cdap-app-templates/cdap-etl/cdap-etl-core/src/main/java/io/cdap/cdap/etl/common/record/StructuredRecordComparator.java b/cdap-app-templates/cdap-etl/cdap-etl-core/src/main/java/io/cdap/cdap/etl/common/record/StructuredRecordComparator.java index 197c7bad159e..cfc032ac9499 100644 --- a/cdap-app-templates/cdap-etl/cdap-etl-core/src/main/java/io/cdap/cdap/etl/common/record/StructuredRecordComparator.java +++ b/cdap-app-templates/cdap-etl/cdap-etl-core/src/main/java/io/cdap/cdap/etl/common/record/StructuredRecordComparator.java @@ -271,7 +271,7 @@ public Iterator iterator() { return ((Collection) array).iterator(); } return new Iterator() { - private int curr = 0; + private int curr; @Override public boolean hasNext() { diff --git a/cdap-app-templates/cdap-etl/cdap-etl-core/src/test/java/io/cdap/cdap/etl/planner/CombinerDagTest.java b/cdap-app-templates/cdap-etl/cdap-etl-core/src/test/java/io/cdap/cdap/etl/planner/CombinerDagTest.java index 6416f7693721..f91bc6fb3e7b 100644 --- a/cdap-app-templates/cdap-etl/cdap-etl-core/src/test/java/io/cdap/cdap/etl/planner/CombinerDagTest.java +++ b/cdap-app-templates/cdap-etl/cdap-etl-core/src/test/java/io/cdap/cdap/etl/planner/CombinerDagTest.java @@ -250,7 +250,7 @@ public void testComplex() { * Deterministically generates group ids. */ private static class GroupIdGenerator implements Supplier { - private int count = 0; + private int count; @Override public String get() { diff --git a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/BatchSparkPipelineDriver.java b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/BatchSparkPipelineDriver.java index 479de6f9099d..4c9bf32b884d 100644 --- a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/BatchSparkPipelineDriver.java +++ b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/BatchSparkPipelineDriver.java @@ -98,7 +98,7 @@ public class BatchSparkPipelineDriver extends SparkPipelineRunner implements Jav private transient DatasetContext datasetContext; private transient Map stagePartitions; private transient FunctionCache.Factory functionCacheFactory; - private transient BatchSQLEngineAdapter sqlEngineAdapter = null; + private transient BatchSQLEngineAdapter sqlEngineAdapter; /** * Empty constructor, used when instantiating this class. diff --git a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/WrappedSQLEngineCollection.java b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/WrappedSQLEngineCollection.java index 03f9de8ca929..2a5aad388585 100644 --- a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/WrappedSQLEngineCollection.java +++ b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/batch/WrappedSQLEngineCollection.java @@ -47,7 +47,7 @@ public class WrappedSQLEngineCollection implements SQLBackedCollection { private final java.util.function.Function, SparkCollection> mapper; private final SQLBackedCollection wrapped; - private SparkCollection unwrapped = null; + private SparkCollection unwrapped; public WrappedSQLEngineCollection(SQLBackedCollection wrapped, java.util.function.Function, SparkCollection> mapper) { diff --git a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/streaming/function/preview/LimitingFunction.java b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/streaming/function/preview/LimitingFunction.java index b780fb2934d1..71e3baebfd73 100644 --- a/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/streaming/function/preview/LimitingFunction.java +++ b/cdap-app-templates/cdap-etl/hydrator-spark-core-base/src/main/java/io/cdap/cdap/etl/spark/streaming/function/preview/LimitingFunction.java @@ -34,7 +34,7 @@ public LimitingFunction(int numOfRecordsLimited) { @Override public JavaRDD call(JavaRDD v1) throws Exception { return v1.filter(new Function() { - int numOfRecordsEmitted = 0; + int numOfRecordsEmitted; @Override public Boolean call(T v1) throws Exception { diff --git a/cdap-app-templates/cdap-etl/hydrator-test/src/main/java/io/cdap/cdap/etl/mock/batch/MockSQLEngine.java b/cdap-app-templates/cdap-etl/hydrator-test/src/main/java/io/cdap/cdap/etl/mock/batch/MockSQLEngine.java index 98b20f04ee6d..8d9f31bcf582 100644 --- a/cdap-app-templates/cdap-etl/hydrator-test/src/main/java/io/cdap/cdap/etl/mock/batch/MockSQLEngine.java +++ b/cdap-app-templates/cdap-etl/hydrator-test/src/main/java/io/cdap/cdap/etl/mock/batch/MockSQLEngine.java @@ -61,8 +61,8 @@ public class MockSQLEngine extends BatchSQLEngine> getRows() { */ public static final class Builder { - private List header = null; - private Iterable> rows = null; + private List header; + private Iterable> rows; public Builder setHeader(String... header) { this.header = Lists.newArrayList(header); diff --git a/cdap-client-tests/src/test/java/io/cdap/cdap/client/util/RESTClientTest.java b/cdap-client-tests/src/test/java/io/cdap/cdap/client/util/RESTClientTest.java index 45d4a12dbc65..c21a109f2ac3 100644 --- a/cdap-client-tests/src/test/java/io/cdap/cdap/client/util/RESTClientTest.java +++ b/cdap-client-tests/src/test/java/io/cdap/cdap/client/util/RESTClientTest.java @@ -254,8 +254,8 @@ public String toString() { @Path("/api") public final class TestHandler extends AbstractHttpHandler { - private int unavailEnpointCount = 0; - private int integer = 0; + private int unavailEnpointCount; + private int integer; private final String message = new UnauthorizedException( new Principal("test", Principal.PrincipalType.USER), ImmutableSet.of(Action.READ, Action.WRITE), diff --git a/cdap-client/src/main/java/io/cdap/cdap/client/config/ConnectionConfig.java b/cdap-client/src/main/java/io/cdap/cdap/client/config/ConnectionConfig.java index 93bf1b7e1c6f..d3d97aee7e76 100644 --- a/cdap-client/src/main/java/io/cdap/cdap/client/config/ConnectionConfig.java +++ b/cdap-client/src/main/java/io/cdap/cdap/client/config/ConnectionConfig.java @@ -154,9 +154,9 @@ public static Builder builder(ConnectionConfig connectionConfig) { */ public static class Builder { private String hostname = DEFAULT_HOST; - private Integer port = null; + private Integer port; private boolean sslEnabled = DEFAULT_SSL_ENABLED; - private String apiPath = null; + private String apiPath; public Builder() { } diff --git a/cdap-common/src/main/java/io/cdap/cdap/common/service/CommandPortService.java b/cdap-common/src/main/java/io/cdap/cdap/common/service/CommandPortService.java index 7e28e0459baa..732056a819e9 100644 --- a/cdap-common/src/main/java/io/cdap/cdap/common/service/CommandPortService.java +++ b/cdap-common/src/main/java/io/cdap/cdap/common/service/CommandPortService.java @@ -164,7 +164,7 @@ public static final class Builder { private final ImmutableMap.Builder handlerBuilder; private final StringBuilder helpStringBuilder; private boolean hasHelp; - private int port = 0; + private int port; /** * Creates a builder for the give name. diff --git a/cdap-common/src/main/java/io/cdap/cdap/common/service/RetryOnStartFailureService.java b/cdap-common/src/main/java/io/cdap/cdap/common/service/RetryOnStartFailureService.java index 890f2422303a..2d0079caf3b4 100644 --- a/cdap-common/src/main/java/io/cdap/cdap/common/service/RetryOnStartFailureService.java +++ b/cdap-common/src/main/java/io/cdap/cdap/common/service/RetryOnStartFailureService.java @@ -44,7 +44,7 @@ public class RetryOnStartFailureService extends AbstractService { private volatile Thread startupThread; private volatile Service currentDelegate; private volatile Service startedService; - private volatile boolean stopped = false; + private volatile boolean stopped; /** * Creates a new instance. diff --git a/cdap-common/src/test/java/io/cdap/cdap/common/async/KeyedExecutorTest.java b/cdap-common/src/test/java/io/cdap/cdap/common/async/KeyedExecutorTest.java index 7b0ea746878c..9a837ac0f372 100644 --- a/cdap-common/src/test/java/io/cdap/cdap/common/async/KeyedExecutorTest.java +++ b/cdap-common/src/test/java/io/cdap/cdap/common/async/KeyedExecutorTest.java @@ -102,7 +102,7 @@ public void testRepeatedTask() throws Exception { try { BlockingQueue queue = new LinkedBlockingQueue<>(); Future future = executor.submit("1", new RepeatedTask() { - private int count = 0; + private int count; @Override public long executeOnce() { diff --git a/cdap-common/src/test/java/io/cdap/cdap/common/logging/SyncTest.java b/cdap-common/src/test/java/io/cdap/cdap/common/logging/SyncTest.java index 07487ab23cff..c25311696284 100644 --- a/cdap-common/src/test/java/io/cdap/cdap/common/logging/SyncTest.java +++ b/cdap-common/src/test/java/io/cdap/cdap/common/logging/SyncTest.java @@ -36,8 +36,8 @@ public class SyncTest { - MiniDFSCluster dfsCluster = null; - Configuration config = null; + MiniDFSCluster dfsCluster; + Configuration config; @Rule public TemporaryFolder tempFolder = new TemporaryFolder(); diff --git a/cdap-common/src/test/java/io/cdap/cdap/common/service/RetryOnStartFailureServiceTest.java b/cdap-common/src/test/java/io/cdap/cdap/common/service/RetryOnStartFailureServiceTest.java index 0d7227c69bfd..463cd272f03d 100644 --- a/cdap-common/src/test/java/io/cdap/cdap/common/service/RetryOnStartFailureServiceTest.java +++ b/cdap-common/src/test/java/io/cdap/cdap/common/service/RetryOnStartFailureServiceTest.java @@ -147,7 +147,7 @@ private Supplier createServiceSupplier(final int startFailures, final boolean failureOnStop) { return new Supplier() { - private int failures = 0; + private int failures; @Override public Service get() { diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/SingleThreadDatasetCache.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/SingleThreadDatasetCache.java index 01168e45cd37..cbb4265b3aae 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/SingleThreadDatasetCache.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/SingleThreadDatasetCache.java @@ -77,7 +77,7 @@ public class SingleThreadDatasetCache extends DynamicDatasetCache { private final Deque extraTxAwares = new LinkedList<>(); private final MetricsContext metricsContext; - private DelayedDiscardingTransactionContext txContext = null; + private DelayedDiscardingTransactionContext txContext; /** * See {@link DynamicDatasetCache}. diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/AddPartitionOperation.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/AddPartitionOperation.java index ec5350d76a1a..96b6797d7503 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/AddPartitionOperation.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/AddPartitionOperation.java @@ -24,7 +24,7 @@ class AddPartitionOperation extends PartitionOperation { private final boolean filesCreated; - private boolean explorePartitionCreated = false; + private boolean explorePartitionCreated; AddPartitionOperation(PartitionKey partitionKey, String relativePath, boolean filesCreated) { super(partitionKey, relativePath); diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetDataset.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetDataset.java index b01630046282..5204da702c8e 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetDataset.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetDataset.java @@ -150,7 +150,7 @@ public PartitionKey apply(PartitionOperation operation) { // this will store the result of getInputKeys() after it is called (the result is needed by // both getInputFormat() and getInputFormatConfiguration(), and we don't want to compute it twice). - private AtomicReference> inputKeysCache = null; + private AtomicReference> inputKeysCache; public PartitionedFileSetDataset(DatasetContext datasetContext, String name, Partitioning partitioning, FileSet fileSet, IndexedTable partitionTable, @@ -1091,7 +1091,7 @@ public void run(io.cdap.cdap.api.data.DatasetContext context) throws Exception { byte[] startRow = startKey.get() == null ? null : generateRowKey(startKey.get(), pfs.getPartitioning()); startKey.set(null); PartitionConsumer consumer = new PartitionConsumer() { - int count = 0; + int count; @Override public void consume(PartitionKey key, String path, @Nullable PartitionMetadata metadata) { diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/AbstractTable.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/AbstractTable.java index fb50d5112f1e..dc2d6779df77 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/AbstractTable.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/AbstractTable.java @@ -270,9 +270,9 @@ public class TableScanner extends SplitReader { // the underlying scanner private Scanner scanner; // the current key - private byte[] key = null; + private byte[] key; // the current row, that is, a map from column key to value - private Map row = null; + private Map row; @Override public void initialize(Split split) throws InterruptedException { diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/BufferingTable.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/BufferingTable.java index 49b85582b41c..0136b49ace7b 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/BufferingTable.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/BufferingTable.java @@ -1070,8 +1070,8 @@ public void close() { } } - private long warnedCount = 0L; - private long skippedCount = 0L; + private long warnedCount; + private long skippedCount; private long warnFrequency = 1L; private void warnAboutEmptyValue(byte[] column) { diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectMappedTableDataset.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectMappedTableDataset.java index a4fcc5a55b23..495c89383d32 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectMappedTableDataset.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectMappedTableDataset.java @@ -204,7 +204,7 @@ public void write(StructuredRecord structuredRecord) throws IOException { private class ObjectIterator extends AbstractCloseableIterator> { private final Scanner scanner; - private boolean closed = false; + private boolean closed; private ObjectIterator(Scanner scanner) { this.scanner = scanner; diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectStoreDataset.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectStoreDataset.java index 4c06b0f15712..8869b78b3c09 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectStoreDataset.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/ObjectStoreDataset.java @@ -102,7 +102,7 @@ public T read(String key) { public CloseableIterator> scan(byte[] startRow, byte[] stopRow) { final CloseableIterator> keyValueIterator = kvTable.scan(startRow, stopRow); return new AbstractCloseableIterator>() { - boolean closed = false; + boolean closed; @Override protected KeyValue computeNext() { Preconditions.checkState(!closed); diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/KeyValue.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/KeyValue.java index 6f845d45ec0f..5203a56896bf 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/KeyValue.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/KeyValue.java @@ -114,12 +114,12 @@ public static Type codeToType(final byte b) { } } - private byte [] bytes = null; - private int offset = 0; - private int length = 0; + private byte [] bytes; + private int offset; + private int length; // the row cached - private volatile byte [] rowCache = null; + private volatile byte [] rowCache; /** * Creates a KeyValue from the start of the specified byte array. @@ -530,7 +530,7 @@ public int getKeyOffset() { /** * Length of key portion. */ - private int keyLength = 0; + private int keyLength; public int getKeyLength() { if (keyLength == 0) { @@ -854,8 +854,8 @@ public SplitKeyValue split() { * Compare key portion of a {@link KeyValue}. */ public static class KeyComparator { - volatile boolean ignoreTimestamp = false; - volatile boolean ignoreType = false; + volatile boolean ignoreTimestamp; + volatile boolean ignoreType; public int compare(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength) { diff --git a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/transaction/TransactionManagerDebuggerMain.java b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/transaction/TransactionManagerDebuggerMain.java index d0553f2e10df..db7c4db21386 100644 --- a/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/transaction/TransactionManagerDebuggerMain.java +++ b/cdap-data-fabric/src/main/java/io/cdap/cdap/data2/transaction/TransactionManagerDebuggerMain.java @@ -99,7 +99,7 @@ private static DebuggerMode fromString(String str) { private DebuggerMode mode; // Mode the tool is used with private String accessToken; // the access token for secure connections - private String tokenFile = null; // path to file which contains an access token + private String tokenFile; // path to file which contains an access token private String hostname; // hostname to take a snapshot from private String existingFilename; // filename where a snapshot has been persisted private Long txId; // transaction ID option diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTableTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTableTest.java index ff70c1e118b8..6ba78b4fcf92 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTableTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/CounterTimeseriesTableTest.java @@ -39,7 +39,7 @@ public class CounterTimeseriesTableTest { @ClassRule public static DatasetFrameworkTestUtil dsFrameworkUtil = new DatasetFrameworkTestUtil(); - private static CounterTimeseriesTable table = null; + private static CounterTimeseriesTable table; private static DatasetId counterTable = DatasetFrameworkTestUtil.NAMESPACE_ID.dataset("counterTable"); @BeforeClass diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/TimeseriesTableScannerTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/TimeseriesTableScannerTest.java index 2dab9974e225..0ced299e9c5a 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/TimeseriesTableScannerTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/api/dataset/lib/TimeseriesTableScannerTest.java @@ -57,8 +57,8 @@ public class TimeseriesTableScannerTest { private static final String SRC_DEVICE_ID_TAG = "src_device_id"; private static final String DEST_DEVICE_ID_TAG = "dest_device_id"; - private static TimeseriesTable table = null; - private static TransactionExecutor txnl = null; + private static TimeseriesTable table; + private static TransactionExecutor txnl; @BeforeClass public static void setup() throws Exception { dsFrameworkUtil.createInstance("timeseriesTable", facts, DatasetProperties.EMPTY); diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/cache/TestDataset.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/cache/TestDataset.java index cc8ffc2de85c..b9a0e79325d6 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/cache/TestDataset.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/cache/TestDataset.java @@ -32,8 +32,8 @@ public class TestDataset extends AbstractDataset implements Comparable args) { super(spec.getName(), kv); diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionConsumerTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionConsumerTest.java index 266f63335d66..309347cbddc3 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionConsumerTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionConsumerTest.java @@ -998,7 +998,7 @@ public void apply() throws Exception { }); } - private int counter = 0; + private int counter; // generates unique partition keys, where the 'i' field is incrementing from 0 upwards on each returned key private PartitionKey generateUniqueKey() { diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetTest.java index 4c47c7afe589..3bfe88116bd2 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/partitioned/PartitionedFileSetTest.java @@ -523,7 +523,7 @@ public boolean apply(PartitionDetail partitionDetail) { }); } - private int counter = 0; + private int counter; // generates unique partition keys, where the 'i' field is incrementing from 0 upwards on each returned key private PartitionKey generateUniqueKey() { return PartitionKey.builder() diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/MetadataStoreDatasetTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/MetadataStoreDatasetTest.java index e2ff859a435c..5add3afb6ad1 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/MetadataStoreDatasetTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/MetadataStoreDatasetTest.java @@ -151,7 +151,7 @@ public void testScan() throws Exception { private static class ScanFunction implements Function, Boolean> { private final List values = new ArrayList<>(); private final int limit; - private int numProcessed = 0; + private int numProcessed; private MDSKey lastKey; public ScanFunction(int limit) { diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableCoreTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableCoreTest.java index 6a3f88adcdbe..04025fb90845 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableCoreTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableCoreTest.java @@ -51,7 +51,7 @@ public class LevelDBTableCoreTest { public static TemporaryFolder tmpFolder = new TemporaryFolder(); static LevelDBTableService service; - static Injector injector = null; + static Injector injector; private final String rowNamePrefix = "row-"; private final String colName = "colName"; diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableServiceTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableServiceTest.java index d66b034c1fd8..ec883fe25fe8 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableServiceTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/dataset2/lib/table/leveldb/LevelDBTableServiceTest.java @@ -60,7 +60,7 @@ public class LevelDBTableServiceTest { public static TemporaryFolder tmpFolder = new TemporaryFolder(); static LevelDBTableService service; - static Injector injector = null; + static Injector injector; @BeforeClass public static void init() throws Exception { diff --git a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/transaction/TransactionContextTest.java b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/transaction/TransactionContextTest.java index 8cb6df32e893..f28fc9be4469 100644 --- a/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/transaction/TransactionContextTest.java +++ b/cdap-data-fabric/src/test/java/io/cdap/cdap/data2/transaction/TransactionContextTest.java @@ -590,11 +590,11 @@ enum InduceFailure { NoFailure, ReturnFalse, ThrowException } static class DummyTxAware implements TransactionAware { Transaction tx; - boolean started = false; - boolean committed = false; - boolean checked = false; - boolean rolledBack = false; - boolean postCommitted = false; + boolean started; + boolean committed; + boolean checked; + boolean rolledBack; + boolean postCommitted; List changes = Lists.newArrayList(); InduceFailure failStartTxOnce = InduceFailure.NoFailure; diff --git a/cdap-elastic/src/main/java/io/cdap/cdap/metadata/elastic/ElasticsearchMetadataStorage.java b/cdap-elastic/src/main/java/io/cdap/cdap/metadata/elastic/ElasticsearchMetadataStorage.java index 7bb80e234653..77644befb4cf 100644 --- a/cdap-elastic/src/main/java/io/cdap/cdap/metadata/elastic/ElasticsearchMetadataStorage.java +++ b/cdap-elastic/src/main/java/io/cdap/cdap/metadata/elastic/ElasticsearchMetadataStorage.java @@ -193,7 +193,7 @@ public class ElasticsearchMetadataStorage implements MetadataStorage { private volatile RestHighLevelClient client; - private volatile boolean created = false; + private volatile boolean created; private int maxWindowSize = Config.DEFAULT_MAX_RESULT_WINDOW; // sleep 100 ms for at most 50 times diff --git a/cdap-explore-client/src/main/java/io/cdap/cdap/explore/client/AbstractExploreClient.java b/cdap-explore-client/src/main/java/io/cdap/cdap/explore/client/AbstractExploreClient.java index 7f8abdd19d5b..a9573685d991 100644 --- a/cdap-explore-client/src/main/java/io/cdap/cdap/explore/client/AbstractExploreClient.java +++ b/cdap-explore-client/src/main/java/io/cdap/cdap/explore/client/AbstractExploreClient.java @@ -411,7 +411,7 @@ private static final class ClientExploreExecutionResult extends AbstractIterator private int fetchSize = DEFAULT_FETCH_SIZE; private Iterator delegate; - private List resultSchema = null; + private List resultSchema; private final ExploreHttpClient exploreClient; private final QueryHandle handle; diff --git a/cdap-explore-client/src/main/java/io/cdap/cdap/explore/service/MetaDataInfo.java b/cdap-explore-client/src/main/java/io/cdap/cdap/explore/service/MetaDataInfo.java index 333b3f9733fb..af4402496d9b 100644 --- a/cdap-explore-client/src/main/java/io/cdap/cdap/explore/service/MetaDataInfo.java +++ b/cdap-explore-client/src/main/java/io/cdap/cdap/explore/service/MetaDataInfo.java @@ -94,7 +94,7 @@ public MetaDataInfo getDefaultValue() { } } - private String stringValue = null; + private String stringValue; private short shortValue; private int intValue; private long longValue; diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/BaseExploreResultSet.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/BaseExploreResultSet.java index fff9e7f88919..ce15a38fac86 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/BaseExploreResultSet.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/BaseExploreResultSet.java @@ -45,9 +45,9 @@ * of a query made to the Explore service. */ abstract class BaseExploreResultSet implements ResultSet { - private boolean isClosed = false; + private boolean isClosed; private int fetchSize; - private boolean wasNull = false; + private boolean wasNull; @Override public boolean isClosed() throws SQLException { diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreConnection.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreConnection.java index 2a1ad3380504..99729b6eae2c 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreConnection.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreConnection.java @@ -54,7 +54,7 @@ public class ExploreConnection implements Connection { private final String namespace; private final ExploreConnectionParams connectionParams; private ExploreClient exploreClient; - private boolean isClosed = false; + private boolean isClosed; ExploreConnection(ExploreClient exploreClient, String namespace, ExploreConnectionParams connectionParams) { this.exploreClient = exploreClient; diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreDatabaseMetaData.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreDatabaseMetaData.java index 68b93f306376..7632f021ae44 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreDatabaseMetaData.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreDatabaseMetaData.java @@ -52,7 +52,7 @@ public class ExploreDatabaseMetaData implements DatabaseMetaData { private final ExploreClient exploreClient; // Cached values, to save on round trips to database. - private String dbVersion = null; + private String dbVersion; public ExploreDatabaseMetaData(ExploreConnection connection, ExploreClient exploreClient) { this.connection = connection; diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExplorePreparedStatement.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExplorePreparedStatement.java index d6fbf2e7e943..7a52d7864f72 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExplorePreparedStatement.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExplorePreparedStatement.java @@ -50,9 +50,9 @@ public class ExplorePreparedStatement extends ExploreStatement implements Prepar private final String sql; - private String lastUpdatedSql = null; - private ResultSet lastResultSet = null; - private boolean lastResultSuccess = false; + private String lastUpdatedSql; + private ResultSet lastResultSet; + private boolean lastResultSuccess; // Save the SQL parameters {paramLoc:paramValue} private final Map parameters = Maps.newHashMap(); diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreResultSet.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreResultSet.java index ef2c44f747e1..edba0811243a 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreResultSet.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreResultSet.java @@ -39,7 +39,7 @@ public class ExploreResultSet extends BaseExploreResultSet { private ExploreResultSetMetaData metaData; private ExploreStatement statement; - private int maxRows = 0; + private int maxRows; private ExploreExecutionResult executionResult; diff --git a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreStatement.java b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreStatement.java index 90b53c2c6916..3aea599d7e8a 100644 --- a/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreStatement.java +++ b/cdap-explore-jdbc/src/main/java/io/cdap/cdap/explore/jdbc/ExploreStatement.java @@ -50,22 +50,22 @@ public class ExploreStatement implements Statement { * statement.getResultSet(); * . */ - private ResultSet resultSet = null; + private ResultSet resultSet; /** * Sets the limit for the maximum number of rows that any ResultSet object produced by this * Statement can contain to the given number. If the limit is exceeded, the excess rows * are silently dropped. The value must be >= 0, and 0 means there is not limit. */ - private int maxRows = 0; + private int maxRows; /** * Add SQLWarnings to the warningChain if needed. */ - private SQLWarning warningChain = null; + private SQLWarning warningChain; - private volatile boolean isClosed = false; - private volatile ListenableFuture futureResults = null; + private volatile boolean isClosed; + private volatile ListenableFuture futureResults; private Connection connection; private ExploreClient exploreClient; diff --git a/cdap-explore/src/main/java/io/cdap/cdap/hive/objectinspector/StandardStructObjectInspector.java b/cdap-explore/src/main/java/io/cdap/cdap/hive/objectinspector/StandardStructObjectInspector.java index 63c865a73ee6..6b8ef3827017 100644 --- a/cdap-explore/src/main/java/io/cdap/cdap/hive/objectinspector/StandardStructObjectInspector.java +++ b/cdap-explore/src/main/java/io/cdap/cdap/hive/objectinspector/StandardStructObjectInspector.java @@ -159,7 +159,7 @@ public List getAllStructFieldRefs() { return fields; } - boolean warned = false; + boolean warned; // With Data @Override diff --git a/cdap-explore/src/test/java/io/cdap/cdap/explore/service/HiveStreamRedirectorTest.java b/cdap-explore/src/test/java/io/cdap/cdap/explore/service/HiveStreamRedirectorTest.java index 83f6d4eac6dc..49b1abf60688 100644 --- a/cdap-explore/src/test/java/io/cdap/cdap/explore/service/HiveStreamRedirectorTest.java +++ b/cdap-explore/src/test/java/io/cdap/cdap/explore/service/HiveStreamRedirectorTest.java @@ -46,7 +46,7 @@ public void testLoggerRedirector() throws Exception { * A logger that increments counters for simple info logs. */ private static final class CountingLogger implements Logger { - private int infoLogs = 0; + private int infoLogs; public int getInfoLogs() { return infoLogs; diff --git a/cdap-explore/src/test/java/io/cdap/cdap/explore/service/datasets/ExtensiveSchemaTableDefinition.java b/cdap-explore/src/test/java/io/cdap/cdap/explore/service/datasets/ExtensiveSchemaTableDefinition.java index 27eeaeb62773..efcdeb469124 100644 --- a/cdap-explore/src/test/java/io/cdap/cdap/explore/service/datasets/ExtensiveSchemaTableDefinition.java +++ b/cdap-explore/src/test/java/io/cdap/cdap/explore/service/datasets/ExtensiveSchemaTableDefinition.java @@ -177,7 +177,7 @@ public static class ExtensiveSchema { private final long date; // Transient and static fields - they shouldn't be included in the schema - private transient int t = 0; + private transient int t; private static int st = 80; // Reference to itself diff --git a/cdap-formats/src/main/java/io/cdap/cdap/format/GrokRecordFormat.java b/cdap-formats/src/main/java/io/cdap/cdap/format/GrokRecordFormat.java index 8012b4fed234..5de9f4e1167a 100644 --- a/cdap-formats/src/main/java/io/cdap/cdap/format/GrokRecordFormat.java +++ b/cdap-formats/src/main/java/io/cdap/cdap/format/GrokRecordFormat.java @@ -48,7 +48,7 @@ public class GrokRecordFormat extends RecordFormat private static final String PATTERN_SETTING = "pattern"; private final Grok grok = new Grok(); - private String pattern = null; + private String pattern; public static Map settings(String pattern) { return ImmutableMap.of(PATTERN_SETTING, pattern); diff --git a/cdap-gateway/src/test/java/io/cdap/cdap/gateway/router/ServerResource.java b/cdap-gateway/src/test/java/io/cdap/cdap/gateway/router/ServerResource.java index 55864fd38c95..527da469e44b 100644 --- a/cdap-gateway/src/test/java/io/cdap/cdap/gateway/router/ServerResource.java +++ b/cdap-gateway/src/test/java/io/cdap/cdap/gateway/router/ServerResource.java @@ -158,7 +158,7 @@ public void upload(FullHttpRequest request, HttpResponder responder) throws Inte public BodyConsumer deploy(HttpRequest request, final HttpResponder responder) throws InterruptedException { return new BodyConsumer() { ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); - int count = 0; + int count; @Override public void chunk(ByteBuf request, HttpResponder responder) { count += request.readableBytes(); diff --git a/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java b/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java index dc7c612097f7..e0343a768852 100644 --- a/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java +++ b/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime from the last WAL Entry replicated is updated to the REPLICATION_STATE table. */ public class LastReplicateTimeObserver extends BaseRegionServerObserver { - private HBase10CDHTableUpdater hBase10CDHTableUpdater = null; + private HBase10CDHTableUpdater hBase10CDHTableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastReplicateTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java b/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java index e8a7811c70d6..51a6ff5e46f0 100644 --- a/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java +++ b/cdap-hbase-compat-1.0-cdh/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime of the last WAL entry is written to the REPLICATION_STATE table. */ public class LastWriteTimeObserver extends BaseWALObserver { - private HBase10CDHTableUpdater hBase10CDHTableUpdater = null; + private HBase10CDHTableUpdater hBase10CDHTableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastWriteTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java b/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java index 2d99a9c87c25..0e64935489e1 100644 --- a/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java +++ b/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime from the last WAL Entry replicated is updated to the REPLICATION_STATE table. */ public class LastReplicateTimeObserver extends BaseRegionServerObserver { - private HBase10CDH550TableUpdater hBase10CDH550TableUpdater = null; + private HBase10CDH550TableUpdater hBase10CDH550TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastReplicateTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java b/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java index 3b1ffe12e710..e91b788c0eef 100644 --- a/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java +++ b/cdap-hbase-compat-1.0-cdh5.5.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime of the last WAL entry is written to the REPLICATION_STATE table. */ public class LastWriteTimeObserver extends BaseWALObserver { - private HBase10CDH550TableUpdater hBase10CDH550TableUpdater = null; + private HBase10CDH550TableUpdater hBase10CDH550TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastWriteTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java b/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java index 21e24a6d136f..32d885f4296b 100644 --- a/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java +++ b/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime from the last WAL Entry replicated is updated to the REPLICATION_STATE table. */ public class LastReplicateTimeObserver extends BaseRegionServerObserver { - private HBase10TableUpdater hBase10TableUpdater = null; + private HBase10TableUpdater hBase10TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastReplicateTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java b/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java index dc9f8f09317f..0e314146c2e1 100644 --- a/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java +++ b/cdap-hbase-compat-1.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime of the last WAL entry is written to the REPLICATION_STATE table. */ public class LastWriteTimeObserver extends BaseWALObserver { - private HBase10TableUpdater hBase10TableUpdater = null; + private HBase10TableUpdater hBase10TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastWriteTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java b/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java index 7d4acc129610..d49f7281fbe2 100644 --- a/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java +++ b/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime from the last WAL Entry replicated is updated to the REPLICATION_STATE table. */ public class LastReplicateTimeObserver extends BaseRegionServerObserver { - private HBase11TableUpdater hBase11TableUpdater = null; + private HBase11TableUpdater hBase11TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastReplicateTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java b/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java index 873c434359b3..a8fa847599d7 100644 --- a/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java +++ b/cdap-hbase-compat-1.1/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime of the last WAL entry is written to the REPLICATION_STATE table. */ public class LastWriteTimeObserver extends BaseWALObserver { - private HBase11TableUpdater hBase11TableUpdater = null; + private HBase11TableUpdater hBase11TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastWriteTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java b/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java index 65c48ac9c1bd..3621475bae2e 100644 --- a/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java +++ b/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastReplicateTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime from the last WAL Entry replicated is updated to the REPLICATION_STATE table. */ public class LastReplicateTimeObserver extends BaseRegionServerObserver { - private HBase12CDH570TableUpdater hBase12CDH570TableUpdater = null; + private HBase12CDH570TableUpdater hBase12CDH570TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastReplicateTimeObserver.class); @Override diff --git a/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java b/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java index 501a8cd1a228..c32df1c3f06e 100644 --- a/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java +++ b/cdap-hbase-compat-1.2-cdh5.7.0/src/main/java/io/cdap/cdap/data2/replication/LastWriteTimeObserver.java @@ -37,7 +37,7 @@ * For each region the writeTime of the last WAL entry is written to the REPLICATION_STATE table. */ public class LastWriteTimeObserver extends BaseWALObserver { - private HBase12CDH570TableUpdater hBase12CDH570TableUpdater = null; + private HBase12CDH570TableUpdater hBase12CDH570TableUpdater; private static final Logger LOG = LoggerFactory.getLogger(LastWriteTimeObserver.class); @Override diff --git a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/data2/util/hbase/HBaseTableUtil.java b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/data2/util/hbase/HBaseTableUtil.java index 0c3edd7d914f..d59186bc91be 100644 --- a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/data2/util/hbase/HBaseTableUtil.java +++ b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/data2/util/hbase/HBaseTableUtil.java @@ -673,8 +673,8 @@ protected void warnGlobalAdminCheckFailure() { * Carries information about table stats */ public static final class TableStats { - private int storeFileSizeMB = 0; - private int memStoreSizeMB = 0; + private int storeFileSizeMB; + private int memStoreSizeMB; TableStats(int storeFileSizeMB, int memStoreSizeMB) { this.storeFileSizeMB = storeFileSizeMB; diff --git a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/hbase/wd/DistributedScanner.java b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/hbase/wd/DistributedScanner.java index 24e2476eb2d7..ffd68597c6cb 100644 --- a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/hbase/wd/DistributedScanner.java +++ b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/hbase/wd/DistributedScanner.java @@ -42,7 +42,7 @@ public class DistributedScanner implements ResultScanner { private final int caching; private final ExecutorService scansExecutor; - private Result next = null; + private Result next; @SuppressWarnings("unchecked") private DistributedScanner(AbstractRowKeyDistributor keyDistributor, @@ -195,7 +195,7 @@ public Iterator iterator() { // Identical to HTable.ClientScanner implementation return new Iterator() { // The next RowResult, possibly pre-read - Result next = null; + Result next; // return true if there is another item pending, false if there isn't. // this method is where the actual advancing takes place, but you need diff --git a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/replication/TableUpdater.java b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/replication/TableUpdater.java index 99ac0438718f..ecc140bd2ad5 100644 --- a/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/replication/TableUpdater.java +++ b/cdap-hbase-compat-base/src/main/java/io/cdap/cdap/replication/TableUpdater.java @@ -41,7 +41,7 @@ public abstract class TableUpdater { public final byte[] columnFamily; public final String rowType; public final Configuration conf; - public boolean tableExists = false; + public boolean tableExists; private class TimeValue { private long time; diff --git a/cdap-master/src/main/java/io/cdap/cdap/data/tools/HBaseTableExporter.java b/cdap-master/src/main/java/io/cdap/cdap/data/tools/HBaseTableExporter.java index 48d9be79a025..626582a8d930 100644 --- a/cdap-master/src/main/java/io/cdap/cdap/data/tools/HBaseTableExporter.java +++ b/cdap-master/src/main/java/io/cdap/cdap/data/tools/HBaseTableExporter.java @@ -82,7 +82,7 @@ public class HBaseTableExporter { private final TransactionService txService; private final ZKClientService zkClientService; private final TransactionSystemClient txClient; - private Path bulkloadDir = null; + private Path bulkloadDir; public HBaseTableExporter() throws Exception { this.hConf = HBaseConfiguration.create(); diff --git a/cdap-master/src/main/java/io/cdap/cdap/data/tools/JobQueueDebugger.java b/cdap-master/src/main/java/io/cdap/cdap/data/tools/JobQueueDebugger.java index d40d0d117b61..0f31959221c0 100644 --- a/cdap-master/src/main/java/io/cdap/cdap/data/tools/JobQueueDebugger.java +++ b/cdap-master/src/main/java/io/cdap/cdap/data/tools/JobQueueDebugger.java @@ -238,9 +238,9 @@ private static final class JobStatistics { @Nullable private Job newestJob; - private int pendingTrigger = 0; - private int pendingConstraint = 0; - private int pendingLaunch = 0; + private int pendingTrigger; + private int pendingConstraint; + private int pendingLaunch; JobStatistics() { this(false); diff --git a/cdap-master/src/main/java/io/cdap/cdap/data/tools/ReplicationStatusTool.java b/cdap-master/src/main/java/io/cdap/cdap/data/tools/ReplicationStatusTool.java index 36fead90f3ce..248e1cc205a1 100644 --- a/cdap-master/src/main/java/io/cdap/cdap/data/tools/ReplicationStatusTool.java +++ b/cdap-master/src/main/java/io/cdap/cdap/data/tools/ReplicationStatusTool.java @@ -88,10 +88,10 @@ public class ReplicationStatusTool { private static final String FILE_OPTION = "f"; private static Long masterShutdownTime = 0L; - private static String inputStatusFileName = null; - private static String outputStatusFileName = null; - private static String dirsFileName = null; - private static long shutDownTimeArgument = 0L; + private static String inputStatusFileName; + private static String outputStatusFileName; + private static String dirsFileName; + private static long shutDownTimeArgument; private static final Gson GSON = new Gson(); diff --git a/cdap-master/src/main/java/org/apache/hadoop/fs/sftp/SFTPConnectionPool.java b/cdap-master/src/main/java/org/apache/hadoop/fs/sftp/SFTPConnectionPool.java index f60f37ae359b..e24f3d05c2a4 100644 --- a/cdap-master/src/main/java/org/apache/hadoop/fs/sftp/SFTPConnectionPool.java +++ b/cdap-master/src/main/java/org/apache/hadoop/fs/sftp/SFTPConnectionPool.java @@ -40,7 +40,7 @@ class SFTPConnectionPool { // live connections than this threshold, any unused connection will be // closed. private int maxConnection; - private int liveConnectionCount = 0; + private int liveConnectionCount; private HashMap> idleConnections = new HashMap>(); private HashMap con2infoMap = diff --git a/cdap-proto/src/main/java/io/cdap/cdap/proto/NamespaceMeta.java b/cdap-proto/src/main/java/io/cdap/cdap/proto/NamespaceMeta.java index a26c4d045f36..5b60ce15f053 100644 --- a/cdap-proto/src/main/java/io/cdap/cdap/proto/NamespaceMeta.java +++ b/cdap-proto/src/main/java/io/cdap/cdap/proto/NamespaceMeta.java @@ -88,7 +88,7 @@ public static final class Builder { private String groupName; private String keytabURIWithoutVersion; private int keytabURIVersion; - private long generation = 0; + private long generation; private boolean exploreAsPrincipal = true; private Map configMap = new HashMap<>(); diff --git a/cdap-security/src/main/java/io/cdap/cdap/security/auth/AbstractKeyManager.java b/cdap-security/src/main/java/io/cdap/cdap/security/auth/AbstractKeyManager.java index 0ce2969982de..930939d5d072 100644 --- a/cdap-security/src/main/java/io/cdap/cdap/security/auth/AbstractKeyManager.java +++ b/cdap-security/src/main/java/io/cdap/cdap/security/auth/AbstractKeyManager.java @@ -52,7 +52,7 @@ public abstract class AbstractKeyManager extends AbstractIdleService implements * Time duration (in milliseconds) after which an active secret key should be retired. A value or zero or less * means no expiration. */ - protected long keyExpirationPeriod = 0; + protected long keyExpirationPeriod; /** diff --git a/cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/classloader/SparkClassRewriter.java b/cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/classloader/SparkClassRewriter.java index ca040bb807c5..3dbc2e61e9af 100644 --- a/cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/classloader/SparkClassRewriter.java +++ b/cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/classloader/SparkClassRewriter.java @@ -694,7 +694,7 @@ private byte[] rewriteTempFileNameForCheckpoint(InputStream byteCodeStream) thro cr.accept(new ClassVisitor(Opcodes.ASM5, cw) { - boolean hasCheckpointTimeField = false; + boolean hasCheckpointTimeField; @Override public FieldVisitor visitField(int access, String name, String descriptor, String signature, Object value) { @@ -715,7 +715,7 @@ public MethodVisitor visitMethod(int access, String name, String desc, String si return new GeneratorAdapter(Opcodes.ASM5, mv, access, name, desc) { - boolean tempStringAddedToStack = false; + boolean tempStringAddedToStack; final Method hadoopPathConstructorMethod = new Method("", Type.VOID_TYPE, new Type[]{ stringType, stringType }); diff --git a/cdap-standalone/src/main/java/org/apache/hadoop/util/ReflectionUtils.java b/cdap-standalone/src/main/java/org/apache/hadoop/util/ReflectionUtils.java index f683e6e959a7..ee9bec2feeed 100644 --- a/cdap-standalone/src/main/java/org/apache/hadoop/util/ReflectionUtils.java +++ b/cdap-standalone/src/main/java/org/apache/hadoop/util/ReflectionUtils.java @@ -53,7 +53,7 @@ public class ReflectionUtils { private static final Class[] EMPTY_ARRAY = new Class[]{}; - private static volatile SerializationFactory serialFactory = null; + private static volatile SerializationFactory serialFactory; /** * Check and set 'configuration' if necessary. @@ -184,7 +184,7 @@ public static synchronized void printThreadInfo(PrintWriter stream, stream.flush(); } - private static long previousLogTime = 0; + private static long previousLogTime; /** * Log the current thread stacks at INFO level. diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractMessageTable.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractMessageTable.java index b445b51b7ae0..a330bc0c5887 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractMessageTable.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractMessageTable.java @@ -123,7 +123,7 @@ private static class FetchIterator extends AbstractCloseableIterator { private final CloseableIterator scanner; private final TransactionMessageFilter filter; private byte[] skipStartRow; - private boolean closed = false; + private boolean closed; private int maxLimit; FetchIterator(CloseableIterator scanner, int limit, @Nullable byte[] skipStartRow, diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractPayloadTable.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractPayloadTable.java index b52909158395..2606098200cb 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractPayloadTable.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/AbstractPayloadTable.java @@ -74,7 +74,7 @@ public CloseableIterator fetch(TopicMetadata metadata, long transactionWr final CloseableIterator scanner = read(startRow, stopRow, limit); return new AbstractCloseableIterator() { - private boolean closed = false; + private boolean closed; private boolean skipFirstRow = !inclusive; @Override diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBaseMessageTable.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBaseMessageTable.java index 2ced6bc8ea90..30b810be4be4 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBaseMessageTable.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBaseMessageTable.java @@ -88,7 +88,7 @@ protected CloseableIterator scan(ScanRequest scanRequest) final ResultScanner scanner = DistributedScanner.create(table, scan, rowKeyDistributor, scanExecutor); final RawMessageTableEntry tableEntry = new RawMessageTableEntry(); return new AbstractCloseableIterator() { - private boolean closed = false; + private boolean closed; @Override protected RawMessageTableEntry computeNext() { diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBasePayloadTable.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBasePayloadTable.java index 7b18b2d96a89..0d5869a62329 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBasePayloadTable.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/hbase/HBasePayloadTable.java @@ -79,7 +79,7 @@ public CloseableIterator read(byte[] startRow, byte[] stop final ResultScanner scanner = DistributedScanner.create(table, scan, rowKeyDistributor, scanExecutor); return new AbstractCloseableIterator() { private final RawPayloadTableEntry tableEntry = new RawPayloadTableEntry(); - private boolean closed = false; + private boolean closed; private int maxLimit = limit; @Override diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/DBScanIterator.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/DBScanIterator.java index 9f9d36fa9a56..cd63d5207436 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/DBScanIterator.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/DBScanIterator.java @@ -33,7 +33,7 @@ final class DBScanIterator extends AbstractCloseableIterator scanTopics(@Nullable byte[] startKey, @Nullable byte[] stopKey) throws IOException { final CloseableIterator> iterator = new DBScanIterator(levelDB, startKey, stopKey); return new AbstractCloseableIterator() { - private boolean closed = false; + private boolean closed; @Override protected TopicMetadata computeNext() { diff --git a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/LevelDBPayloadTable.java b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/LevelDBPayloadTable.java index efd9e2922704..66df55b63add 100644 --- a/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/LevelDBPayloadTable.java +++ b/cdap-tms/src/main/java/io/cdap/cdap/messaging/store/leveldb/LevelDBPayloadTable.java @@ -65,7 +65,7 @@ protected CloseableIterator read(byte[] startRow, byte[] s final DBScanIterator iterator = new DBScanIterator(levelDB, startRow, stopRow); return new AbstractCloseableIterator() { private final RawPayloadTableEntry tableEntry = new RawPayloadTableEntry(); - private boolean closed = false; + private boolean closed; private int maxLimit = limit; @Override diff --git a/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/MessageTableTest.java b/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/MessageTableTest.java index 4e7b6d1ee01e..e64dbae15ba3 100644 --- a/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/MessageTableTest.java +++ b/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/MessageTableTest.java @@ -268,7 +268,7 @@ public void testConcurrentWrites() throws Exception { public Void call() throws Exception { try (MessageTable messageTable = getMessageTable(metadata)) { messageTable.store(new AbstractIterator() { - int messageCount = 0; + int messageCount; @Override protected MessageTable.Entry computeNext() { diff --git a/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/PayloadTableTest.java b/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/PayloadTableTest.java index 8660550ec4bb..8312b72f0a73 100644 --- a/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/PayloadTableTest.java +++ b/cdap-tms/src/test/java/io/cdap/cdap/messaging/store/PayloadTableTest.java @@ -159,7 +159,7 @@ public void testConcurrentWrites() throws Exception { public Void call() throws Exception { try (PayloadTable payloadTable = getPayloadTable(metadata)) { payloadTable.store(new AbstractIterator() { - short messageCount = 0; + short messageCount; @Override protected PayloadTable.Entry computeNext() { diff --git a/cdap-unit-test/src/test/java/io/cdap/cdap/partitioned/AppWritingToPartitioned.java b/cdap-unit-test/src/test/java/io/cdap/cdap/partitioned/AppWritingToPartitioned.java index 53e391c797be..df859bd5ede7 100644 --- a/cdap-unit-test/src/test/java/io/cdap/cdap/partitioned/AppWritingToPartitioned.java +++ b/cdap-unit-test/src/test/java/io/cdap/cdap/partitioned/AppWritingToPartitioned.java @@ -119,7 +119,7 @@ public static class TokenMapper extends Mapper implements ProgramLifecycle> { MapReduceTaskContext taskContext; - String[] outputs = null; + String[] outputs; @Override public void initialize(MapReduceTaskContext context) throws Exception { diff --git a/cdap-unit-test/src/test/java/io/cdap/cdap/service/DynamicPluginServiceApp.java b/cdap-unit-test/src/test/java/io/cdap/cdap/service/DynamicPluginServiceApp.java index 1bf42f472582..44fc32ddbda9 100644 --- a/cdap-unit-test/src/test/java/io/cdap/cdap/service/DynamicPluginServiceApp.java +++ b/cdap-unit-test/src/test/java/io/cdap/cdap/service/DynamicPluginServiceApp.java @@ -78,7 +78,7 @@ protected void configure() { public static class DynamicPluginHandler extends AbstractHttpServiceHandler { private static final Gson GSON = new Gson(); private static final Type MAP_TYPE = new TypeToken>() { }.getType(); - private boolean onFinishSuccessful = false; + private boolean onFinishSuccessful; @POST @Path("plugins/{name}/apply") @@ -137,7 +137,7 @@ public void producePluginFunction(HttpServiceRequest request, HttpServiceRespond PluginConfigurer pluginConfigurer = getContext().createServicePluginConfigurer(getNamespace(request)); HttpContentProducer producer = new HttpContentProducer() { - private boolean done = false; + private boolean done; @Override public ByteBuffer nextChunk(Transactional transactional) { diff --git a/cdap-unit-test/src/test/java/io/cdap/cdap/test/app/AppWithCustomTx.java b/cdap-unit-test/src/test/java/io/cdap/cdap/test/app/AppWithCustomTx.java index ea0aa8cbf8d0..0941e10804dc 100644 --- a/cdap-unit-test/src/test/java/io/cdap/cdap/test/app/AppWithCustomTx.java +++ b/cdap-unit-test/src/test/java/io/cdap/cdap/test/app/AppWithCustomTx.java @@ -375,7 +375,7 @@ public HttpContentConsumer tx(HttpServiceRequest request, HttpServiceResponder r return new HttpContentConsumer() { - String body = null; + String body; @Override public void onReceived(ByteBuffer chunk, Transactional transactional) throws Exception { @@ -471,7 +471,7 @@ public HttpContentConsumer notx(HttpServiceRequest request, HttpServiceResponder executeAttemptNestedTransaction(getContext(), HANDLER_NOTX, RUNTIME_NEST); return new HttpContentConsumer() { - String body = null; + String body; @Override public void onReceived(ByteBuffer chunk, Transactional transactional) throws Exception { @@ -726,7 +726,7 @@ public List getSplits(JobContext context) throws IOException, Interr public RecordReader createRecordReader(InputSplit split, TaskAttemptContext context) throws IOException, InterruptedException { return new RecordReader() { - private int count = 0; + private int count; @Override public void initialize(InputSplit split, TaskAttemptContext context) throws IOException, InterruptedException { } diff --git a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/AbstractChunkedLogProducer.java b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/AbstractChunkedLogProducer.java index 49a7de60b826..6b08811dec90 100644 --- a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/AbstractChunkedLogProducer.java +++ b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/AbstractChunkedLogProducer.java @@ -39,8 +39,8 @@ public abstract class AbstractChunkedLogProducer extends BodyProducer { private final CloseableIterator logEventIter; - private boolean hasStarted = false; - private boolean hasFinished = false; + private boolean hasStarted; + private boolean hasFinished; AbstractChunkedLogProducer(CloseableIterator logEventIter) { this.logEventIter = logEventIter; diff --git a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/pipeline/logbuffer/LogBufferProcessorPipeline.java b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/pipeline/logbuffer/LogBufferProcessorPipeline.java index 0392a3c0940c..273991c513a3 100644 --- a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/pipeline/logbuffer/LogBufferProcessorPipeline.java +++ b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/pipeline/logbuffer/LogBufferProcessorPipeline.java @@ -307,7 +307,7 @@ public String toString() { */ private final class LogFileOffsetTransformIterator implements Iterator> { private final BlockingQueue queue; - private int count = 0; + private int count; LogFileOffsetTransformIterator(BlockingQueue queue) { this.queue = queue; diff --git a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/FileLogReader.java b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/FileLogReader.java index 8df8de4d6513..af49511b4ec4 100644 --- a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/FileLogReader.java +++ b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/FileLogReader.java @@ -163,7 +163,7 @@ public void close() { CloseableIterator> closeableIterator = new CloseableIterator>() { - private CloseableIterator curr = null; + private CloseableIterator curr; @Override public void close() { diff --git a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/KafkaLogReader.java b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/KafkaLogReader.java index 65b9f3534d3b..2d4657217d5c 100644 --- a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/KafkaLogReader.java +++ b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/read/KafkaLogReader.java @@ -231,8 +231,8 @@ private static class KafkaCallback implements io.cdap.cdap.logging.kafka.Callbac private LogOffset firstOffset; private LogOffset lastOffset; - private int eventsMatched = 0; - private int eventsRead = 0; + private int eventsMatched; + private int eventsRead; private KafkaCallback(Filter logFilter, LoggingEventSerializer serializer, long stopOffset, int maxEvents, Callback callback, long fromTimeMs) { diff --git a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/write/LogLocation.java b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/write/LogLocation.java index 9efb2aa6f4b5..34bea7048274 100644 --- a/cdap-watchdog/src/main/java/io/cdap/cdap/logging/write/LogLocation.java +++ b/cdap-watchdog/src/main/java/io/cdap/cdap/logging/write/LogLocation.java @@ -263,7 +263,7 @@ private final class LogEventIterator implements CloseableIterator { private ILoggingEvent loggingEvent; private GenericRecord datum; - private int count = 0; + private int count; private long prevTimestamp = -1; private LogEvent next; diff --git a/checkstyle.xml b/checkstyle.xml index 28336eb3141c..e1a6232fdc7d 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -289,6 +289,8 @@ page at http://checkstyle.sourceforge.net/config.html --> + +