Skip to content

Commit e8220ee

Browse files
kaizenccgithub-actions
and
github-actions
authored
feat: npm source bucket is versioned (#1693)
The source bucket stores state -- the marker sequence and the list of known versions that have already been ingested. we are currently resetting the state without backing the old state up, and when the new state is malformed we have no way of rolling back. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent 8471b3c commit e8220ee

File tree

3 files changed

+37
-0
lines changed

3 files changed

+37
-0
lines changed

src/__tests__/__snapshots__/construct-hub.test.ts.snap

+30
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/__tests__/devapp/__snapshots__/snapshot.test.ts.snap

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/package-sources/npmjs.ts

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ export class NpmJs implements IPackageSource {
121121
storageFactory.newBucket(scope, 'NpmJs/StagingBucket', {
122122
blockPublicAccess: BlockPublicAccess.BLOCK_ALL,
123123
enforceSSL: true,
124+
versioned: true, // we store state in this bucket; versions backup old state
124125
lifecycleRules: [
125126
{
126127
prefix: S3KeyPrefix.STAGED_KEY_PREFIX,

0 commit comments

Comments
 (0)