Enable shell completion of ucm
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `postInstall` was never getting executed (because `installPhase` was missing `runHook postInstall`). So I added the missing `runHooks`. However, that errored, as the `--runtime-path` (set by the wrapper) and `--*-completion-script` options don’t work together. To avoid that, I generated the completions for the wrapped command from the unwrapped command.
sellout
force-pushed
the
fix-shell-completion
branch
from
fe8be03 to
40dae90
Compare
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
postInstallwas never getting executed (becauseinstallPhasewas missingrunHook postInstall). So I added the missingrunHooks.However, that errored, as the
--runtime-path(set by the wrapper) and--*-completion-scriptoptions don’t work together. To avoid that, I generated the completions for the wrapped command from the unwrapped command.