Add the VS Code extension for Unison #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could also split this into two PRs … |
It was getting too long to keep in the flake, and it works better as an example on its own. I also documented the HM config a bit, and made some changes that made more sense once it was extracted: - added a tree-sitter grammar derivation to packages; - moved `self.lib.tree-sitter-grammars` to `self.overlays.tree-sitter`; - overlaid the Unison tree-sitter grammar on the `nvim-treesitter` Vim plugin; - added our overlay to Nixpkgs in the HM config, rather than `import nixpkgs …`; - split up the Home Manager sections to make the distinct configs more obvious; - made the Emacs’ config _slightly_ less annoying; - removed `programs.emacs.package` (Emacs 29 is the default now); - added `programs.neovim` to the HM config; and - updated `home.stateVersion`. [^1]: I was hoping to get rid of the former, since there is now a derivation for the grammar, but it seems `pkgs.tree-sitter` wants to make all its derivations itself.
sellout
force-pushed
the
vscode-support
branch
from
bd21198 to
08fbb09
Compare
|
Thanks! I'll try to take a closer look at this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing the commits separately.
The second one does a lot of rejiggering of the Home Manager configuration. The commit message for this one is likely helpful. If it makes things easier, I can split this into two commits – one that extracts the file, with minimal changes just to get things compiling, then a second that makes the rest of the changes.
The third one adds a GitHub check for the Home Manager configuration.