Skip to content

SYCL_KHR_QUEUE_FLUSH implementation and optional extension mechanism #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PeterTh
Copy link
Collaborator

@PeterTh PeterTh commented Jul 17, 2025

This is a continuation of #44, adding the ability to configure the availability of the extension, as well as (and this is the larger part) a new CI action which checks that this mechanism is actually working.

@PeterTh PeterTh changed the title Sycl khr queue flush SYCL_KHR_QUEUE_FLUSH implementation and optional extension mechanism Jul 17, 2025
@PeterTh
Copy link
Collaborator Author

PeterTh commented Jul 17, 2025

@TApplencourt please have a quick look to see if this suits your needs, if so I'll merge it.

@TApplencourt
Copy link

Thanks a lot for your time on it!

LGTM, except that I don't really understand why the CI doesn't have a Configure CMake for extension check program (with extensions) , but my CMake skills are poor, and I didn't even get my coffee : )

Please merge it at your convenience, or you can also wait for the SYCL WG to merge the KHR first if you prefer to be "save",

Thanks again

@PeterTh
Copy link
Collaborator Author

PeterTh commented Jul 17, 2025

LGTM, except that I don't really understand why the CI doesn't have a Configure CMake for extension check program (with extensions)

That's a valid question, because the lack of symmetry is jarring -- I actually considered doing that step for that reason despite it not being required and not actually doing anything.

The reason it is not necessary is because the configuration change will change the installed SimSYCL the test is built against, but it's still in the same location. So the CMake configuration of the test does not need to change.

I think I'll wait with merging until the KHR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants