Fix filter with ArrayValue, issue #29

Author: Jeroen van der Heijden

.gitignore

@@ -18,3 +18,9 @@ build/
 
 # Mac
 .DS_Store
+
+# Json test data
+*.json
+
+# Local test
+/ltest.py

aiogcd/orm/properties/arrayvalue.py

@@ -28,10 +28,10 @@ def __init__(self, default=None, required=True, accept=None):
         super().__init__(default=default, required=required)
 
     def check_value(self, value):
-        if not isinstance(value, list):
+        if not isinstance(value, (list, tuple)):
             raise TypeError(
-                'Expecting an value of type \'int\' for property {!r} '
-                'but received type {!r}.'
+                'Expecting an value of type \'list\' or \'tuple\' for '
+                'property {!r} but received type {!r}.'
                 .format(self.name, value.__class__.__name__))
 
         if self._accept and \
@@ -40,6 +40,18 @@ def check_value(self, value):
                 'At least one item in array property {!r} has an invalid type.'
                 .format(self.name))
 
+    def check_compare(self, value):
+        """Ignore a compare for an array value as a value van be given which
+        filters all entities where the array contains the given value.
+
+        Suppose there exists an entity with an `arr` property with the array
+            [123, 456, 789]
+
+        The following would return that entity:
+            Entity.filter(Entity.arr == 456)
+        """
+        pass
+
     def _protect(self, value):
         if self._accept and not isinstance(value, self._accept):
             raise TypeError('Invalid type {!r} for array property {!r}.'

aiogcd/orm/properties/value.py

@@ -25,14 +25,17 @@ def descending(self):
     def check_value(self, value):
         raise NotImplementedError()
 
+    def check_compare(self, value):
+        return self.check_value(value)
+
     def get_value(self, model):
         return model.__dict__.get(self.name, None)
 
     def set_value(self, model, value):
         Entity.set_property(model, self.name, value)
 
     def _compare(self, other, op):
-        self.check_value(other)
+        self.check_compare(other)
         return {
             'property': {
                 'name': self.name

setup.py

@@ -15,7 +15,7 @@
 import setuptools
 from distutils.core import setup, Extension
 
-VERSION = '0.11.12'
+VERSION = '0.11.13'
 
 install_requires = [
     'aiohttp>=2',