Remove the --filename flag and update the -f description (#2215)

Signed-off-by: Rafał Kuć <[email protected]>
Signed-off-by: Rafał Kuć <[email protected]>
Co-authored-by: Miguel Martinez Trivino <[email protected]>

Author: gr0

app/cli/cmd/plugins.go

@@ -245,7 +245,6 @@ func newPluginDescribeCmd() *cobra.Command {
 
 func newPluginInstallCmd() *cobra.Command {
 	var file string
-	var filename string
 	var location string
 
 	cmd := &cobra.Command{
@@ -257,7 +256,6 @@ func newPluginInstallCmd() *cobra.Command {
 
 			opts := &action.PluginInstallOptions{
 				File:     file,
-				Filename: filename,
 				Location: location,
 			}
 
@@ -272,8 +270,7 @@ func newPluginInstallCmd() *cobra.Command {
 	}
 
 	// Common flags
-	cmd.Flags().StringVarP(&file, "file", "f", "", "URL of the plugin to download (required)")
-	cmd.Flags().StringVarP(&filename, "filename", "", "", "Custom filename to save the plugin as (optional)")
+	cmd.Flags().StringVarP(&file, "file", "f", "", "URL or path to the plugin to install")
 	cobra.CheckErr(cmd.MarkFlagRequired("file"))
 
 	return cmd

app/cli/documentation/cli-reference.mdx

@@ -1281,9 +1281,8 @@ chainloop config plugin install [flags]
 Options
 
 ```
--f, --file string       URL of the plugin to download (required)
---filename string   Custom filename to save the plugin as (optional)
--h, --help              help for install
+-f, --file string   URL or path to the plugin to install
+-h, --help          help for install
 ```
 
 Options inherited from parent commands

app/cli/internal/action/plugin_actions.go

@@ -172,10 +172,7 @@ func (action *PluginInstall) Run(_ context.Context, opts *PluginInstallOptions)
 
 	// determine filename
 	filename := filepath.Base(opts.File)
-	if opts.Filename != "" {
-		filename = opts.Filename
-		action.cfg.Logger.Debug().Str("customFilename", opts.Filename).Msg("Using custom filename")
-	} else if filename == "." || filename == "/" {
+	if filename == "." || filename == "/" {
 		action.cfg.Logger.Error().Str("file", opts.File).Msg("Invalid URL or object key, could not determine filename")
 		return nil, fmt.Errorf("invalid URL or object key, could not determine filename")
 	}