Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode bucket names in the Census codebase #1181

Open
ebezzi opened this issue Jun 4, 2024 · 1 comment
Open

Do not hardcode bucket names in the Census codebase #1181

ebezzi opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
2024-q4 P0 Priority 0 - Critical, fix ASAP! Priority backlog items python api Related to the API

Comments

@ebezzi
Copy link
Member

ebezzi commented Jun 4, 2024

Currently, the bucket name for the embeddings is hardcoded in the Census codebase. This is not ideal: if we need to move the bucket, it will break previous versions.

At least for embeddings, we should use the following approach:

  1. Add an embedding_uri field to the manifest which points to the location of the artifact on S3
  2. Replace the code that uses the hardcoded bucket location with such URI

We should also ensure that the same pattern doesn't get added for indexes.

@ebezzi ebezzi added the tech label Jun 4, 2024
@pablo-gar pablo-gar added census builder Related to the census builder tool python api Related to the API P0 Priority 0 - Critical, fix ASAP! and removed tech census builder Related to the census builder tool labels Jun 4, 2024
@ebezzi
Copy link
Member Author

ebezzi commented Jul 8, 2024

embedding_uri has been added to the manifest, so the only remaining part is to incorporate it in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-q4 P0 Priority 0 - Critical, fix ASAP! Priority backlog items python api Related to the API
Projects
None yet
Development

No branches or pull requests

3 participants